tag with git hash

[BenTheElder]

Something changed and our automatic image builds now have fancy git describe output instead of just the date+hash.

This would ensure we keep using date+hash.

I think that's probably the best move for now.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [BenTheElder]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[BenTheElder]

@aojea @stmcginnis WDYT?

[aojea]

you are the expert on these things

[BenTheElder]

I think we should, because the commit hash only changes if we rewrite history.

[BenTheElder]

Also I think the git tags detected are wrong on recently pushed base etc images (v0.29.0....) ... better to just drop that, we only need date-sha for uniqueness and traceability, we're not advertising semver in these images

[stmcginnis]

Yeah, makes sense to me. And good point about semver. I think that may have been misleading to some people.

/lgtm