fix(ci): recognize approved gates after GitHub rewrites details_url - #7272
Merged
zhangzujian merged 1 commit intoAug 20, 2026
Merged
Conversation
The reducer waited for x86-e2e / required-gate with a custom pull-request details_url. GitHub Actions overwrites that field to /runs/<id>, so approved /test e2e never dispatched an executor. Match the durable reservation by external_id, action_required, and summary instead. Signed-off-by: Zujian Zhang <zhangzujian.7@gmail.com>
dosubot
Bot
added
size:S
Coverage Report for CI Build 32330134020Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage decreased (-0.004%) to 32.744%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions2 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
/test e2e coreon #7260 recorded a durable approval, then the reducertimed out waiting for:
The live check run is:
GitHub Actions rewrites
details_urlto the check's/runs/<id>URL, sothe reducer never dispatched the isolated executor. Match the reservation
by
external_id,action_required, and the waiting-executor summary.Which issue(s) this PR fixes
Follow-up to #7267 / #7268 / #7270. Seen on
https://github.com/kubeovn/kube-ovn/actions/runs/32326793300