Skip to content

fix(ci): accept unbound /test e2e comments and post replies - #7267

Merged
zhangzujian merged 1 commit into
kubeovn:masterfrom
zhangzujian:fix/e2e-comment-unbound-command
Aug 20, 2026
Merged

fix(ci): accept unbound /test e2e comments and post replies#7267
zhangzujian merged 1 commit into
kubeovn:masterfrom
zhangzujian:fix/e2e-comment-unbound-command

Conversation

@zhangzujian

Copy link
Copy Markdown
Member

What this PR does / why we need it

On #7260, /test e2e core did not start E2E.

The dispatcher requires an exact --head <sha> --nonce <nonce> binding, so
the natural command is invalid E2E command. The rejection reply then 403s
(Resource not accessible by integration) because the trusted token can
read PRs but cannot create PR comments. The later bound command was
accepted, then failed in Record the approved request on the same 403,
so no trusted executor started.

This change:

  • accepts /test e2e, /test e2e <groups>, /test e2e-all, and
    /retest e2e-failed and binds them to the live HEAD at dispatch time
  • still honors and validates explicit --head/--nonce when present
  • grants pull-requests: write so rejection and approval-marker comments
    can post

Which issue(s) this PR fixes

Follow-up to #7244. Seen on
https://github.com/kubeovn/kube-ovn/actions/runs/32324230046
and
https://github.com/kubeovn/kube-ovn/actions/runs/32326007147

Related to #7230.

`/test e2e core` was rejected as invalid without --head/--nonce, and the
rejection reply 403ed because the dispatcher token could not write PR
comments. Bind live HEAD when the comment omits the nonce, and grant
pull-requests: write so trusted replies and approval markers can post.

Signed-off-by: Zujian Zhang <zhangzujian.7@gmail.com>
@zhangzujian
zhangzujian requested a review from oilbeater as a code owner August 20, 2026 02:53
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. ci github_actions Pull requests that update GitHub Actions code labels Aug 20, 2026
@zhangzujian
zhangzujian merged commit c82351f into kubeovn:master Aug 20, 2026
35 checks passed
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 32326266835

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage decreased (-0.004%) to 32.744%

Details

  • Coverage decreased (-0.004%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 2 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

2 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
pkg/ovs/ovn-nb-logical_router_route.go 2 75.73%

Coverage Stats

Coverage Status
Relevant Lines: 64588
Covered Lines: 21149
Line Coverage: 32.74%
Coverage Strength: 0.38 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci github_actions Pull requests that update GitHub Actions code size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants