Skip to content
This repository was archived by the owner on Sep 19, 2022. It is now read-only.

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Nov 18, 2018

Registry in the params are not overriden for the argo steps


This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.877% when pulling b06ac4a on johnugeorge:registryfix into 0a021e5 on kubeflow:master.

@coveralls
Copy link

coveralls commented Nov 18, 2018

Coverage Status

Coverage increased (+0.06%) to 66.937% when pulling 677acf1 on johnugeorge:registryfix into 0a021e5 on kubeflow:master.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 959ebb4 into kubeflow:master Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants