Skip to content
This repository was archived by the owner on Sep 19, 2022. It is now read-only.

Commit 959ebb4

Browse files
johnugeorgek8s-ci-robot
authored andcommitted
Fix registry override for image builds (#102)
* Fix registry override for image builds * Fix registry override for image builds * Adding project to prow_config * Adding project to prow_config
1 parent 0a021e5 commit 959ebb4

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

prow_config.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ workflows:
77
job_types:
88
- presubmit
99
params:
10+
project: "kubeflow-ci"
1011
registry: "gcr.io/kubeflow-ci"
1112
# The postsubmit run publishes the docker images to gcr.io/kubeflow-images-public
1213
- app_dir: kubeflow/pytorch-operator/test/workflows
@@ -15,4 +16,5 @@ workflows:
1516
job_types:
1617
- postsubmit
1718
params:
19+
project: "kubeflow-images-public"
1820
registry: "gcr.io/kubeflow-images-public"

test/workflows/components/workflows.libsonnet

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
},
3838

3939
// overrides is a dictionary of parameters to provide in addition to defaults.
40-
parts(namespace, name, overrides={}):: {
40+
parts(namespace, name, overrides):: {
4141
// Workflow to run the e2e test.
4242
e2e(prow_env, bucket):
4343
local params = $.defaultParams + overrides;
@@ -283,44 +283,44 @@
283283
],
284284
},
285285
}, // checkout
286-
$.parts(namespace, name).e2e(prow_env, bucket).buildTemplate("setup-cluster", testWorkerImage, [
286+
$.parts(namespace, name, overrides).e2e(prow_env, bucket).buildTemplate("setup-cluster", testWorkerImage, [
287287
"scripts/create-cluster.sh",
288288
]), // setup cluster
289-
$.parts(namespace, name).e2e(prow_env, bucket).buildTemplate("setup-kubeflow", testWorkerImage, [
289+
$.parts(namespace, name, overrides).e2e(prow_env, bucket).buildTemplate("setup-kubeflow", testWorkerImage, [
290290
"scripts/setup-kubeflow.sh",
291291
]), // setup kubeflow
292-
$.parts(namespace, name).e2e(prow_env, bucket).buildTemplate("run-v1alpha1-defaults", testWorkerImage, [
292+
$.parts(namespace, name, overrides).e2e(prow_env, bucket).buildTemplate("run-v1alpha1-defaults", testWorkerImage, [
293293
"scripts/v1alpha1/run-defaults.sh",
294294
]), // run v1alpha1 default tests
295-
$.parts(namespace, name).e2e(prow_env, bucket).buildTemplate("setup-v1alpha2", testWorkerImage, [
295+
$.parts(namespace, name, overrides).e2e(prow_env, bucket).buildTemplate("setup-v1alpha2", testWorkerImage, [
296296
"scripts/v1alpha2/setup-v1alpha2.sh",
297297
]), // setup operator v1alpha2 version
298-
$.parts(namespace, name).e2e(prow_env, bucket).buildTemplate("run-v1alpha2-defaults", testWorkerImage, [
298+
$.parts(namespace, name, overrides).e2e(prow_env, bucket).buildTemplate("run-v1alpha2-defaults", testWorkerImage, [
299299
"scripts/v1alpha2/run-defaults.sh",
300300
]), // run v1alpha2 default tests
301-
$.parts(namespace, name).e2e(prow_env, bucket).buildTemplate("run-v1alpha2-cleanpodpolicy-all", testWorkerImage, [
301+
$.parts(namespace, name, overrides).e2e(prow_env, bucket).buildTemplate("run-v1alpha2-cleanpodpolicy-all", testWorkerImage, [
302302
"scripts/v1alpha2/run-cleanpodpolicy-all.sh",
303303
]), // run v1alpha2 cleanpodpolicy tests
304-
$.parts(namespace, name).e2e(prow_env, bucket).buildTemplate("create-pr-symlink", testWorkerImage, [
304+
$.parts(namespace, name, overrides).e2e(prow_env, bucket).buildTemplate("create-pr-symlink", testWorkerImage, [
305305
"python",
306306
"-m",
307307
"kubeflow.testing.prow_artifacts",
308308
"--artifacts_dir=" + outputDir,
309309
"create_pr_symlink",
310310
"--bucket=" + bucket,
311311
]), // create-pr-symlink
312-
$.parts(namespace, name).e2e(prow_env, bucket).buildTemplate("teardown-cluster", testWorkerImage, [
312+
$.parts(namespace, name, overrides).e2e(prow_env, bucket).buildTemplate("teardown-cluster", testWorkerImage, [
313313
"scripts/delete-cluster.sh",
314314
]), // teardown cluster
315-
$.parts(namespace, name).e2e(prow_env, bucket).buildTemplate("copy-artifacts", testWorkerImage, [
315+
$.parts(namespace, name, overrides).e2e(prow_env, bucket).buildTemplate("copy-artifacts", testWorkerImage, [
316316
"python",
317317
"-m",
318318
"kubeflow.testing.prow_artifacts",
319319
"--artifacts_dir=" + outputDir,
320320
"copy_artifacts",
321321
"--bucket=" + bucket,
322322
]), // copy-artifacts
323-
$.parts(namespace, name).e2e(prow_env, bucket).buildTemplate("build", testWorkerImage, [
323+
$.parts(namespace, name, overrides).e2e(prow_env, bucket).buildTemplate("build", testWorkerImage, [
324324
"scripts/build.sh",
325325
]), // build
326326
], // templates

0 commit comments

Comments
 (0)