Skip to content

test: update Kind bootstrap to Kubernetes 1.36#3490

Merged
google-oss-prow[bot] merged 1 commit into
kubeflow:masterfrom
danish9039:kind-0-32-k8s-1-36
Jun 4, 2026
Merged

test: update Kind bootstrap to Kubernetes 1.36#3490
google-oss-prow[bot] merged 1 commit into
kubeflow:masterfrom
danish9039:kind-0-32-k8s-1-36

Conversation

@danish9039

@danish9039 danish9039 commented Jun 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Update the shared Kind bootstrap script to Kind v0.32.0 and the Kind Kubernetes v1.36.1 node image from the upstream Kind release.
  • Update the kubeadmConfigPatches payload to kubeadm.k8s.io/v1beta4 and the list-shaped apiServer.extraArgs format used by Kubernetes v1.36+.

Validation

  • bash -n tests/install_KinD_create_KinD_cluster_install_kustomize.sh
  • git diff --check HEAD~1..HEAD
  • Local temporary-home smoke test: ran tests/install_KinD_create_KinD_cluster_install_kustomize.sh; confirmed kind v0.32.0, kubectl client v1.36.1, kustomize v5.8.1, and all three kubeflow Kind nodes Ready on Kubernetes v1.36.1 with containerd 2.3.1.

Copilot AI review requested due to automatic review settings June 2, 2026 21:45
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

Welcome to the Kubeflow Manifests Repository

Thanks for opening your first PR. Your contribution means a lot to the Kubeflow community.

Before making more PRs:
Please ensure your PR follows our Contributing Guide.
Please also be aware that many components are synchronizes from upstream via the scripts in /scripts.
So in some cases you have to fix the problem in the upstream repositories first, but you can use a PR against kubeflow/manifests to test the platform integration.

Community Resources:

Thanks again for helping to improve Kubeflow.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the KinD bootstrap script to use newer KinD/Kubernetes versions and aligns the kubeadm patch format accordingly, with tests added to prevent regressions.

Changes:

  • Bump KinD to v0.32.0 and the node image to Kubernetes v1.36.1 (pinned by digest).
  • Update kubeadm config patch from kubeadm.k8s.io/v1beta3 to v1beta4 and adjust apiServer.extraArgs formatting.
  • Add a Python test suite that validates the bootstrap script contents (versions, kubeadm format, and absence of stale containerd mirror patches).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
tests/kind_bootstrap_upgrade_test.py Adds tests asserting the bootstrap script contains the expected versions/patch format and omits stale settings.
tests/install_KinD_create_KinD_cluster_install_kustomize.sh Updates KinD + node image versions and changes kubeadm config patch API/version and extraArgs structure.

Comment thread tests/install_KinD_create_KinD_cluster_install_kustomize.sh
Comment thread tests/kind_bootstrap_upgrade_test.py Outdated
Comment thread tests/kind_bootstrap_upgrade_test.py Outdated
Comment thread tests/kind_bootstrap_upgrade_test.py Outdated
@google-oss-prow google-oss-prow Bot added size/S and removed size/M labels Jun 2, 2026
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@danish9039 danish9039 force-pushed the kind-0-32-k8s-1-36 branch from a5f1db1 to dbb269f Compare June 2, 2026 22:55
@juliusvonkohout juliusvonkohout marked this pull request as ready for review June 4, 2026 08:39
@google-oss-prow google-oss-prow Bot requested a review from kimwnasptd June 4, 2026 08:40
@juliusvonkohout

Copy link
Copy Markdown
Member

Thank you
/lgtm
/approve

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit b3ebffb into kubeflow:master Jun 4, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants