test: update Kind bootstrap to Kubernetes 1.36#3490
Conversation
|
Welcome to the Kubeflow Manifests Repository Thanks for opening your first PR. Your contribution means a lot to the Kubeflow community. Before making more PRs: Community Resources:
Thanks again for helping to improve Kubeflow. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the KinD bootstrap script to use newer KinD/Kubernetes versions and aligns the kubeadm patch format accordingly, with tests added to prevent regressions.
Changes:
- Bump KinD to v0.32.0 and the node image to Kubernetes v1.36.1 (pinned by digest).
- Update kubeadm config patch from
kubeadm.k8s.io/v1beta3tov1beta4and adjustapiServer.extraArgsformatting. - Add a Python test suite that validates the bootstrap script contents (versions, kubeadm format, and absence of stale containerd mirror patches).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tests/kind_bootstrap_upgrade_test.py | Adds tests asserting the bootstrap script contains the expected versions/patch format and omits stale settings. |
| tests/install_KinD_create_KinD_cluster_install_kustomize.sh | Updates KinD + node image versions and changes kubeadm config patch API/version and extraArgs structure. |
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
a5f1db1 to
dbb269f
Compare
|
Thank you |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
v0.32.0and the Kind Kubernetesv1.36.1node image from the upstream Kind release.kubeadmConfigPatchespayload tokubeadm.k8s.io/v1beta4and the list-shapedapiServer.extraArgsformat used by Kubernetesv1.36+.Validation
bash -n tests/install_KinD_create_KinD_cluster_install_kustomize.shgit diff --check HEAD~1..HEADtests/install_KinD_create_KinD_cluster_install_kustomize.sh; confirmedkind v0.32.0,kubectlclientv1.36.1,kustomize v5.8.1, and all threekubeflowKind nodes Ready on Kubernetesv1.36.1with containerd2.3.1.