Skip to content

chery-pick changes from master#1648

Merged
k8s-ci-robot merged 3 commits into
kubeflow:v1.2-branchfrom
thesuperzapper:prepare_1.2
Nov 16, 2020
Merged

chery-pick changes from master#1648
k8s-ci-robot merged 3 commits into
kubeflow:v1.2-branchfrom
thesuperzapper:prepare_1.2

Conversation

@thesuperzapper

Copy link
Copy Markdown
Member

Cherry picking changes from master

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@thesuperzapper

Copy link
Copy Markdown
Member Author

@Jeffwan here is a chery-pick of the changes I made today for the components owned by wg-notebook

@Jeffwan

Jeffwan commented Nov 16, 2020

Copy link
Copy Markdown
Member

/lgtm
/approve

@Jeffwan

Jeffwan commented Nov 16, 2020

Copy link
Copy Markdown
Member

/cc @Bobgy @PatrickXYS who has permission to approve

This is cherry-pick PR and reviewed yesterday. We need to cut a new RC release once it's merged

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@Jeffwan: GitHub didn't allow me to request PR reviews from the following users: approve, who, has, permission, to.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @Bobgy @PatrickXYS who has permission to approve

This is cherry-pick PR and reviewed yesterday. We need to cut a new RC release once it's merged

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PatrickXYS

Copy link
Copy Markdown
Member

/lgtm
/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, PatrickXYS, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9d9aa08 into kubeflow:v1.2-branch Nov 16, 2020
@thesuperzapper thesuperzapper deleted the prepare_1.2 branch November 16, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants