Skip to content

fix application selectors#1646

Merged
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
thesuperzapper:fix_app_selectors
Nov 16, 2020
Merged

fix application selectors#1646
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
thesuperzapper:fix_app_selectors

Conversation

@thesuperzapper

@thesuperzapper thesuperzapper commented Nov 16, 2020

Copy link
Copy Markdown
Member

Which issue is resolved by this Pull Request:
Resolves #1573 (for components owned by wg-notebook)

Description of your changes:

Fixes the Application resource selectors for:

  • webhook (PodDefaults)
  • centraldashboard
  • jupyter-web-app
  • notebook-controller
  • profiles

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@google-cla google-cla Bot added the cla: yes label Nov 16, 2020
@thesuperzapper

thesuperzapper commented Nov 16, 2020

Copy link
Copy Markdown
Member Author

@jlewi @Bobgy can you please review? (this needs to get into Kubeflow 1.2)

@thesuperzapper

thesuperzapper commented Nov 16, 2020

Copy link
Copy Markdown
Member Author

I intended to tag @Jeffwan

@Bobgy

Bobgy commented Nov 16, 2020

Copy link
Copy Markdown
Contributor

What blocks you from approving by yourself?
Can you send a PR to add OWNERS?

@Bobgy

Bobgy commented Nov 16, 2020

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot

k8s-ci-robot commented Nov 16, 2020

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3e88eab into kubeflow:master Nov 16, 2020
@thesuperzapper thesuperzapper mentioned this pull request Nov 16, 2020
Closed
thesuperzapper added a commit to thesuperzapper/manifests that referenced this pull request Nov 16, 2020
@thesuperzapper
fix application selectors (kubeflow#1646)
be71ea4 
(cherry picked from commit 3e88eab)
k8s-ci-robot pushed a commit that referenced this pull request Nov 16, 2020
@thesuperzapper
chery-pick changes from master (#1648)
9d9aa08 
* update jupyter config with tolerations/selectors (#1644)

(cherry picked from commit 051f31a)

* update image tags (#1645)

(cherry picked from commit fdd3204)

* fix application selectors (#1646)

(cherry picked from commit 3e88eab)
@thesuperzapper thesuperzapper deleted the fix_app_selectors branch November 16, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krishnadurai krishnadurai Awaiting requested review from krishnadurai

@pvaneck pvaneck Awaiting requested review from pvaneck

Assignees

@Bobgy Bobgy

Labels

approved cla: yes lgtm size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

most Application Resource Selectors are Incorrect

3 participants

@thesuperzapper @Bobgy @k8s-ci-robot