Skip to content

update jupyter config with tolerations/selectors#1644

Merged
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
thesuperzapper:fix_notebook_config
Nov 16, 2020
Merged

update jupyter config with tolerations/selectors#1644
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
thesuperzapper:fix_notebook_config

Conversation

@thesuperzapper

Copy link
Copy Markdown
Member

Description of your changes:

Updates the default spawner_ui_config.yaml with new sections for the tolerations/selectors feature.

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@thesuperzapper

Copy link
Copy Markdown
Member Author

@Jeffwan can you review? (this needs to get into Kubeflow 1.2)

@Jeffwan

Jeffwan commented Nov 16, 2020

Copy link
Copy Markdown
Member

/lgtm

@Jeffwan

Jeffwan commented Nov 16, 2020

Copy link
Copy Markdown
Member

I see the other PR on the image tag update.

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 051f31a into kubeflow:master Nov 16, 2020
thesuperzapper added a commit to thesuperzapper/manifests that referenced this pull request Nov 16, 2020
k8s-ci-robot pushed a commit that referenced this pull request Nov 16, 2020
* update jupyter config with tolerations/selectors (#1644)

(cherry picked from commit 051f31a)

* update image tags (#1645)

(cherry picked from commit fdd3204)

* fix application selectors (#1646)

(cherry picked from commit 3e88eab)
@Bobgy

Bobgy commented Nov 18, 2020

Copy link
Copy Markdown
Contributor

@thesuperzapper can you inform me what do platform owners need to do with this config?

@thesuperzapper

Copy link
Copy Markdown
Member Author

@Bobgy if your stack has a copy of the spawner_ui_config.yaml file, you probably want to update it to include the new config fields: spawnerFormDefaults.affinityConfig and spawnerFormDefaults.tolerationGroup

You can simply use the value of the default one: https://github.com/kubeflow/manifests/blob/master/jupyter/jupyter-web-app/base/configs/spawner_ui_config.yaml

@Bobgy

Bobgy commented Nov 18, 2020

Copy link
Copy Markdown
Contributor

Thanks, GCP is directly using base_v3, I believe it's fine then.

@thesuperzapper thesuperzapper deleted the fix_notebook_config branch November 16, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants