update jupyter config with tolerations/selectors#1644
Conversation
|
@Jeffwan can you review? (this needs to get into Kubeflow 1.2) |
|
/lgtm |
|
I see the other PR on the image tag update. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan, thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
(cherry picked from commit 051f31a)
|
@thesuperzapper can you inform me what do platform owners need to do with this config? |
|
@Bobgy if your stack has a copy of the You can simply use the value of the default one: https://github.com/kubeflow/manifests/blob/master/jupyter/jupyter-web-app/base/configs/spawner_ui_config.yaml |
|
Thanks, GCP is directly using base_v3, I believe it's fine then. |
Description of your changes:
Updates the default
spawner_ui_config.yamlwith new sections for the tolerations/selectors feature.Checklist:
cd manifests/testsmake generate-changed-onlymake test