Add kfdef 1.2 manifests#1620
Merged
Merged
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm @Jeffwan You can unhold if you want to merge the PR |
Member
Author
|
/hold cancel |
Jeffwan
added a commit
to Jeffwan/manifests
that referenced
this pull request
Nov 9, 2020
* Add kfdef 1.2 manifests * Add README.md
k8s-ci-robot
pushed a commit
that referenced
this pull request
Nov 10, 2020
* Add kfdef 1.2 manifests * Add README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #1597
Description of your changes:
I copy from 1.1 manifests and only change manifest resource to v1.2-branch. The reason I didn't pin to tag is because we are in RC phase and I assume they might be some bug fixed. Let's start to test it and once there's a stable RC, we can pin to tag later.
This change will be cherry-pick back to v1.2-branch after it merges.
/cc @PatrickXYS @animeshsingh @adrian555 @nakfour
Checklist:
cd manifests/testsmake generate-changed-onlymake test