Skip to content

Delete Deployment manager configs for GCP#1538

Merged
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
virgoaugustine:master
Sep 8, 2020
Merged

Delete Deployment manager configs for GCP#1538
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
virgoaugustine:master

Conversation

@virgoaugustine

@virgoaugustine virgoaugustine commented Sep 1, 2020

Copy link
Copy Markdown
Contributor

Which issue is resolved by this Pull Request:
Resolves #1537

Description of your changes:
Deleted the Deployment manager configs since they are no longer used from Kubeflow v1.1 upwards.

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@kubeflow-bot

Copy link
Copy Markdown
Contributor

This change is Reviewable

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @virgoaugustine. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@virgoaugustine

virgoaugustine commented Sep 1, 2020

Copy link
Copy Markdown
Contributor Author

/cc @jlewi

@jlewi

jlewi commented Sep 8, 2020

Copy link
Copy Markdown
Contributor

Thanks!
/lgtm
/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deployment manager configs are no longer used starting with Kubeflow 1.1.

4 participants