Skip to content

Modifying cluster-kubeflow.yaml file to update GCP GKE version for Kubeflow v1.0#1536

Closed
virgoaugustine wants to merge 1 commit into
kubeflow:v1.0-branchfrom
virgoaugustine:v1.0-branch
Closed

Modifying cluster-kubeflow.yaml file to update GCP GKE version for Kubeflow v1.0#1536
virgoaugustine wants to merge 1 commit into
kubeflow:v1.0-branchfrom
virgoaugustine:v1.0-branch

Conversation

@virgoaugustine

@virgoaugustine virgoaugustine commented Sep 1, 2020

Copy link
Copy Markdown
Contributor

Which issue is resolved by this Pull Request:
Resolves #1519

Description of your changes:
Changed the "cluster-version" from 1.14 to 1.15 on the v1.0-branch.

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @virgoaugustine. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeflow-bot

Copy link
Copy Markdown
Contributor

This change is Reviewable

@virgoaugustine

Copy link
Copy Markdown
Contributor Author

cc @jlewi

@virgoaugustine

Copy link
Copy Markdown
Contributor Author

@jlewi

jlewi commented Sep 14, 2020

Copy link
Copy Markdown
Contributor

/lgtm
/approve
Thanks for the fix.

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@virgoaugustine: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-manifests-presubmit daf491d link /test kubeflow-manifests-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@virgoaugustine

Copy link
Copy Markdown
Contributor Author

/retest

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@virgoaugustine: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlewi

jlewi commented Sep 18, 2020

Copy link
Copy Markdown
Contributor

Closing this PR. @virgoaugustine deleted the DM configs in #1538 so I don't think this PR is relevant anymore.

@jlewi jlewi closed this Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants