add parameter for istio gateway in oidc-authservice#1123
Conversation
|
Hi @thesuperzapper. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@krishnadurai, can you please review this? |
|
/ok-to-test |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions. |
f8dfe9f to
737d2ad
Compare
|
@animeshsingh I have rebased, but cant see whats is failing. |
|
/retest |
737d2ad to
26fc6a4
Compare
26fc6a4 to
7dd615e
Compare
|
@krishnadurai I finally got the tests to pass, can you please review? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krishnadurai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
this allows the use of non-default istio ingress gateways, by implementing a kustomize parameter
Checklist:
cd manifests/testsmake generate-changed-onlymake test