Skip to content

add parameter for istio gateway in oidc-authservice#1123

Merged
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
thesuperzapper:feature/support_gateway_paramater_oidc
Aug 26, 2020
Merged

add parameter for istio gateway in oidc-authservice#1123
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
thesuperzapper:feature/support_gateway_paramater_oidc

Conversation

@thesuperzapper

@thesuperzapper thesuperzapper commented Apr 21, 2020

Copy link
Copy Markdown
Member

Description of your changes:
this allows the use of non-default istio ingress gateways, by implementing a kustomize parameter

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@kubeflow-bot

Copy link
Copy Markdown
Contributor

This change is Reviewable

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @thesuperzapper. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thesuperzapper

Copy link
Copy Markdown
Member Author

@krishnadurai, can you please review this?

@krishnadurai

Copy link
Copy Markdown
Contributor

/ok-to-test

@stale

stale Bot commented Aug 24, 2020

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions.

@thesuperzapper thesuperzapper force-pushed the feature/support_gateway_paramater_oidc branch from f8dfe9f to 737d2ad Compare August 25, 2020 04:41
@stale stale Bot removed the lifecycle/stale label Aug 25, 2020
@thesuperzapper

Copy link
Copy Markdown
Member Author

@animeshsingh I have rebased, but cant see whats is failing.

@thesuperzapper

Copy link
Copy Markdown
Member Author

/retest

@thesuperzapper thesuperzapper force-pushed the feature/support_gateway_paramater_oidc branch from 737d2ad to 26fc6a4 Compare August 26, 2020 07:05
@thesuperzapper thesuperzapper force-pushed the feature/support_gateway_paramater_oidc branch from 26fc6a4 to 7dd615e Compare August 26, 2020 07:22
@thesuperzapper

Copy link
Copy Markdown
Member Author

@krishnadurai I finally got the tests to pass, can you please review?

@krishnadurai

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krishnadurai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 13e0220 into kubeflow:master Aug 26, 2020
@thesuperzapper thesuperzapper deleted the feature/support_gateway_paramater_oidc branch November 16, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants