Skip to content

add parameter for istio gateway in oidc-authservice #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
Aug 26, 2020
Merged

add parameter for istio gateway in oidc-authservice #1123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion istio/oidc-authservice/base/envoy-filter.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
name: authn-filter
spec:
workloadLabels:
istio: ingressgateway
istio: $(gatewaySelector)
filters:
- filterConfig:
httpService:
Expand Down
7 changes: 7 additions & 0 deletions istio/oidc-authservice/base/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,13 @@ vars:
apiVersion: v1
fieldref:
fieldpath: data.namespace
- name: gatewaySelector
objref:
kind: ConfigMap
name: oidc-authservice-parameters
apiVersion: v1
fieldref:
fieldpath: data.gatewaySelector
configurations:
- params.yaml
images:
Expand Down
3 changes: 2 additions & 1 deletion istio/oidc-authservice/base/params.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@ application_secret=pUBnBOY80SnXgjibTYM9ZWNzY2xreNGQok
skip_auth_uri=
userid-header=
userid-prefix=
namespace=istio-system
namespace=istio-system
gatewaySelector=ingressgateway
2 changes: 2 additions & 0 deletions istio/oidc-authservice/base/params.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,6 @@ varReference:
- path: spec/filters/filterConfig/httpService/serverUri/uri
kind: EnvoyFilter
- path: spec/filters/filterConfig/httpService/serverUri/cluster
kind: EnvoyFilter
- path: spec/workloadLabels/istio
kind: EnvoyFilter
1 change: 1 addition & 0 deletions ...tion/oidc-authservice/test_data/expected/~g_v1_configmap_oidc-authservice-parameters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ apiVersion: v1
data:
application_secret: pUBnBOY80SnXgjibTYM9ZWNzY2xreNGQok
client_id: kubeflow-oidc-authservice
gatewaySelector: ingressgateway
namespace: istio-system
oidc_auth_url: /dex/auth
oidc_provider: http://dex.auth.svc.cluster.local:5556/dex
Expand Down
1 change: 1 addition & 0 deletions ...tion/oidc-authservice/test_data/expected/~g_v1_configmap_oidc-authservice-parameters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ apiVersion: v1
data:
application_secret: pUBnBOY80SnXgjibTYM9ZWNzY2xreNGQok
client_id: kubeflow-oidc-authservice
gatewaySelector: ingressgateway
namespace: istio-system
oidc_auth_url: /dex/auth
oidc_provider: http://dex.auth.svc.cluster.local:5556/dex
Expand Down
1 change: 1 addition & 0 deletions ...tion/oidc-authservice/test_data/expected/~g_v1_configmap_oidc-authservice-parameters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ apiVersion: v1
data:
application_secret: pUBnBOY80SnXgjibTYM9ZWNzY2xreNGQok
client_id: kubeflow-oidc-authservice
gatewaySelector: ingressgateway
namespace: istio-system
oidc_auth_url: /dex/auth
oidc_provider: http://dex.auth.svc.cluster.local:5556/dex
Expand Down