Skip to content

fix application specs#1106

Merged
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
thesuperzapper:fix_application_specs
Sep 11, 2020
Merged

fix application specs#1106
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
thesuperzapper:fix_application_specs

Conversation

@thesuperzapper

Copy link
Copy Markdown
Member

Description of your changes:

  • ensure descriptor field is correctly set
  • ensure addOwnerRef=true

@kubeflow-bot

Copy link
Copy Markdown
Contributor

This change is Reviewable

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @thesuperzapper. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krishnadurai krishnadurai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Perhaps other owners should also take a look.

/assign @johnugeorge @cliveseldon

@krishnadurai

Copy link
Copy Markdown
Contributor

/ok-to-test

@thesuperzapper

Copy link
Copy Markdown
Member Author

@krishnadurai I don't really understand what is failing

@thesuperzapper thesuperzapper force-pushed the fix_application_specs branch from 3fe75ea to cb76cad Compare May 26, 2020 02:11
@k8s-ci-robot k8s-ci-robot removed the lgtm label May 26, 2020
@thesuperzapper

Copy link
Copy Markdown
Member Author

@krishnadurai can you please review?

@stale

stale Bot commented Aug 24, 2020

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions.

@thesuperzapper

Copy link
Copy Markdown
Member Author

@krishnadurai @johnugeorge these very basic bugs are still in the YAML, can we please get this merged to fix these?

The current YAML structure is simply incorrect, (in addition to the missing addOwnerRef).

@ukclivecox

Copy link
Copy Markdown
Contributor

/approve

@thesuperzapper

Copy link
Copy Markdown
Member Author

/assign @Jeffwan @krishnadurai

@thesuperzapper

Copy link
Copy Markdown
Member Author

@Jeffwan @krishnadurai gentle ping, this bug is really simple, I would really appreciate if you can review it.

@krishnadurai krishnadurai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@thesuperzapper

Copy link
Copy Markdown
Member Author

@Jeffwan only waiting on you now :)

@thesuperzapper

Copy link
Copy Markdown
Member Author

@terrytangyuan you can also approve the final remaining change because you are in mpi-job/OWNERS

@terrytangyuan terrytangyuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon, krishnadurai, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thesuperzapper

Copy link
Copy Markdown
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 365b598 into kubeflow:master Sep 11, 2020
@thesuperzapper thesuperzapper deleted the fix_application_specs branch November 16, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants