fix application specs#1106
Conversation
|
Hi @thesuperzapper. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
@krishnadurai I don't really understand what is failing |
3fe75ea to
cb76cad
Compare
|
@krishnadurai can you please review? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions. |
cb76cad to
dd606a3
Compare
dd606a3 to
41d2194
Compare
|
@krishnadurai @johnugeorge these very basic bugs are still in the YAML, can we please get this merged to fix these? The current YAML structure is simply incorrect, (in addition to the missing |
41d2194 to
71768f7
Compare
|
/approve |
|
/assign @Jeffwan @krishnadurai |
|
@Jeffwan @krishnadurai gentle ping, this bug is really simple, I would really appreciate if you can review it. |
|
@Jeffwan only waiting on you now :) |
|
@terrytangyuan you can also approve the final remaining change because you are in |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cliveseldon, krishnadurai, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Description of your changes: