Skip to content

manifests: align default to #1113#1137

Merged
google-oss-prow[bot] merged 1 commit into
kubeflow:mainfrom
tarilabs:tarilabs-20250520
May 20, 2025
Merged

manifests: align default to #1113#1137
google-oss-prow[bot] merged 1 commit into
kubeflow:mainfrom
tarilabs:tarilabs-20250520

Conversation

@tarilabs

Copy link
Copy Markdown
Member

Description

follow-up to

for consistency of the defaults (considered without the kustomize)

How Has This Been Tested?

GHAs

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>

@tarilabs tarilabs left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit 4d361d0 into kubeflow:main May 20, 2025
16 checks passed
tarilabs added a commit to tarilabs/kubeflow-manifests that referenced this pull request May 20, 2025
Signed-off-by: tarilabs <matteo.mortari@gmail.com>
google-oss-prow Bot pushed a commit to kubeflow/community-distribution that referenced this pull request May 21, 2025
* Update kubeflow/model-registry manifests from v0.2.18

Signed-off-by: tarilabs <matteo.mortari@gmail.com>

* update GHA dry-run test

Signed-off-by: tarilabs <matteo.mortari@gmail.com>

Co-authored-by: Alessio Pragliola <83355398+Al-Pragliola@users.noreply.github.com>

* update full_kubeflow_integration_test MR test

Signed-off-by: tarilabs <matteo.mortari@gmail.com>

Co-authored-by: Alessio Pragliola <83355398+Al-Pragliola@users.noreply.github.com>

* aligns with kubeflow/hub#1137

Signed-off-by: tarilabs <matteo.mortari@gmail.com>

---------

Signed-off-by: tarilabs <matteo.mortari@gmail.com>
Co-authored-by: Alessio Pragliola <83355398+Al-Pragliola@users.noreply.github.com>
@juliusvonkohout

Copy link
Copy Markdown
Member

@tarilabs if you want regular security updates, then newTag: 8.3 or 8.4 for mysql is probably better than the static 8.3.0. KFP uses mysql:8.4 i think

@tarilabs

Copy link
Copy Markdown
Member Author

@tarilabs if you want regular security updates, then newTag: 8.3 or 8.4 for mysql is probably better than the static 8.3.0. KFP uses mysql:8.4 i think

logged as #1144 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants