Skip to content

Update kubeflow/model-registry manifests from v0.2.18#3137

Merged
google-oss-prow[bot] merged 4 commits into
kubeflow:masterfrom
tarilabs:synchronize-kubeflow-model-registry-manifests-v0.2.18
May 21, 2025
Merged

Update kubeflow/model-registry manifests from v0.2.18#3137
google-oss-prow[bot] merged 4 commits into
kubeflow:masterfrom
tarilabs:synchronize-kubeflow-model-registry-manifests-v0.2.18

Conversation

@tarilabs

Copy link
Copy Markdown
Member

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

periodic sync following the MR release

📦 Dependencies

n/a

🐛 Related Issues

n/a

✅ Contributor Checklist

  • I have tested these changes with kustomize. See Installation Prerequisites.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Signed-off-by: tarilabs <matteo.mortari@gmail.com>
@google-oss-prow google-oss-prow Bot requested review from Tomcli and kimwnasptd May 19, 2025 14:53

@Al-Pragliola Al-Pragliola left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to update the GHA tests in .github/workflows/model_registry_test.yaml

and update from | kubectl apply -f - to | kubectl apply -n kubeflow -f -
in lines 55/56/60

@tarilabs

Signed-off-by: tarilabs <matteo.mortari@gmail.com>

Co-authored-by: Alessio Pragliola <83355398+Al-Pragliola@users.noreply.github.com>
@tarilabs tarilabs force-pushed the synchronize-kubeflow-model-registry-manifests-v0.2.18 branch from 87c53cd to 5ca2cf7 Compare May 19, 2025 15:17
@Al-Pragliola

Copy link
Copy Markdown
Contributor

sorry @tarilabs I missed the .github/workflows/full_kubeflow_integration_test.yaml file

seems like it needs the same modifications on lines 90/91/95

Signed-off-by: tarilabs <matteo.mortari@gmail.com>

Co-authored-by: Alessio Pragliola <83355398+Al-Pragliola@users.noreply.github.com>

@Al-Pragliola Al-Pragliola left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Comment thread apps/model-registry/upstream/README.md
Comment thread apps/model-registry/upstream/README.md
Comment thread apps/model-registry/upstream/overlays/db/model-registry-db-deployment.yaml Outdated
Signed-off-by: tarilabs <matteo.mortari@gmail.com>
@google-oss-prow google-oss-prow Bot removed the lgtm label May 20, 2025
@tarilabs tarilabs requested a review from juliusvonkohout May 20, 2025 19:10
@juliusvonkohout

Copy link
Copy Markdown
Member

@tarilabs if you want regular security updates, then newTag: 8.3 or 8.4 for mysql is probably better than the static 8.3.0.

/lgtm
/approve

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit 40af7fe into kubeflow:master May 21, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants