Skip to content

Helm charts Kserve Models Web App #3183

Merged
google-oss-prow[bot] merged 8 commits into
kubeflow:masterfrom
kunal-511:kserve-models-web-app-helm-charts
Aug 11, 2025
Merged

Helm charts Kserve Models Web App #3183
google-oss-prow[bot] merged 8 commits into
kubeflow:masterfrom
kunal-511:kserve-models-web-app-helm-charts

Conversation

@kunal-511

Copy link
Copy Markdown
Contributor

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

  Helm Charts For Models Web app

📦 Dependencies

List any dependencies or related PRs (e.g., "Depends on #123").

🐛 Related Issues

Link any issues that are resolved or affected by this PR.

✅ Contributor Checklist

  • I have tested these changes with kustomize. See Installation Prerequisites.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

@juliusvonkohout

Copy link
Copy Markdown
Member

probably it makes sense to now create subfolders in /tests for each component, but let me unblock you first
/lgtm
/approve

- 'tests/models_web_app_compare_manifests.py'
- '.github/workflows/kserve-models-web-app-comparison.yml'
workflow_dispatch:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where are the permissions for the gha ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added now

@juliusvonkohout

Copy link
Copy Markdown
Member

/hold

@juliusvonkohout juliusvonkohout force-pushed the kserve-models-web-app-helm-charts branch from 9f52ee3 to 3c45668 Compare July 21, 2025 08:25
@juliusvonkohout

juliusvonkohout commented Jul 21, 2025

Copy link
Copy Markdown
Member

/hold

i think /tests is gettind crowded and there seems to be code duplication. Please check that there are not multiple scripts for the sme thing and also how we can reduce the number of files in /tests in general.
image For example we could merge PSS baseline and restricted or do other things, but we somehow need to reduce the amount of files to not lose the overview. We could also use subfolders, as we have them for kserve.

@kunal-511 kunal-511 force-pushed the kserve-models-web-app-helm-charts branch from 3c45668 to a0fcff1 Compare July 28, 2025 04:59
@juliusvonkohout

Copy link
Copy Markdown
Member

/hold

i think /tests is gettind crowded and there seems to be code duplication. Please check that there are not multiple scripts for the sme thing and also how we can reduce the number of files in /tests in general. image For example we could merge PSS baseline and restricted or do other things, but we somehow need to reduce the amount of files to not lose the overview. We could also use subfolders, as we have them for kserve.

i will wait for this before merging. we are getting too many files in one folder.

@kunal-511

Copy link
Copy Markdown
Contributor Author

/hold

i think /tests is gettind crowded and there seems to be code duplication. Please check that there are not multiple scripts for the sme thing and also how we can reduce the number of files in /tests in general. image For example we could merge PSS baseline and restricted or do other things, but we somehow need to reduce the amount of files to not lose the overview. We could also use subfolders, as we have them for kserve.

I have removed the duplication in /tests

@juliusvonkohout

Copy link
Copy Markdown
Member

Please fix the tests

kunal-511 and others added 6 commits August 5, 2025 20:23
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@kunal-511 kunal-511 force-pushed the kserve-models-web-app-helm-charts branch from 21442f4 to 7cf42fd Compare August 5, 2025 14:56
@kunal-511

Copy link
Copy Markdown
Contributor Author

I think the errors in helm comparison is due to upgrade to model-registry to v0.2.21.
So updating the model-registry helm charts according to it

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511

Copy link
Copy Markdown
Contributor Author

@juliusvonkohout it is now ready for review

@juliusvonkohout

Copy link
Copy Markdown
Member

/lgtm
/approve

@google-oss-prow google-oss-prow Bot added the lgtm label Aug 11, 2025
@juliusvonkohout

Copy link
Copy Markdown
Member

/unhold

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit 8f1bbf6 into kubeflow:master Aug 11, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants