Helm charts Kserve Models Web App #3183
Conversation
|
probably it makes sense to now create subfolders in /tests for each component, but let me unblock you first |
| - 'tests/models_web_app_compare_manifests.py' | ||
| - '.github/workflows/kserve-models-web-app-comparison.yml' | ||
| workflow_dispatch: | ||
|
|
There was a problem hiding this comment.
where are the permissions for the gha ?
|
/hold |
9f52ee3 to
3c45668
Compare
3c45668 to
a0fcff1
Compare
|
Please fix the tests |
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
21442f4 to
7cf42fd
Compare
|
I think the errors in helm comparison is due to upgrade to model-registry to v0.2.21. |
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
|
@juliusvonkohout it is now ready for review |
|
/lgtm |
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |



Pull Request Template for Kubeflow Manifests
✏️ Summary of Changes
📦 Dependencies
🐛 Related Issues
✅ Contributor Checklist