Skip to content

Commit 8f1bbf6

Browse files
Helm charts Kserve Models Web App (#3183)
* Kserve Models Web App Helm charts Signed-off-by: kunal-511 <yoyokvunal@gmail.com> * Gha for comparision Signed-off-by: kunal-511 <yoyokvunal@gmail.com> * Added permissions Signed-off-by: kunal-511 <yoyokvunal@gmail.com> * Removed duplication of comparision from the tests directory Signed-off-by: kunal-511 <yoyokvunal@gmail.com> * Removed extra files Signed-off-by: kunal-511 <yoyokvunal@gmail.com> * Update pipelines_swfs_install.sh Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * Migrate model-registry helm charts to v0.2.21 Signed-off-by: kunal-511 <yoyokvunal@gmail.com> * Migrate model registry helm charts to v0.2.21 Signed-off-by: kunal-511 <yoyokvunal@gmail.com> --------- Signed-off-by: kunal-511 <yoyokvunal@gmail.com> Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> Co-authored-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
1 parent d740b62 commit 8f1bbf6

43 files changed

Lines changed: 1747 additions & 729 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/helm-kustomize-comparison.yml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,18 @@ on:
44
pull_request:
55
branches: [master]
66
paths:
7-
- 'charts/**'
8-
- '/applications/model-registry/**'
9-
- 'tests/helm_compare_all_scenarios.sh'
7+
- 'experimental/helm/charts/**'
8+
- 'applications/model-registry/**'
9+
- 'tests/helm_kustomize_compare.py'
1010
- 'tests/helm_kustomize_compare.sh'
11-
- 'tests/helm_compare_manifests.py'
12-
- 'helm-kustomize-comparison.yml'
11+
- 'tests/helm_kustomize_compare_all.sh'
12+
- '.github/workflows/helm-kustomize-comparison.yml'
1313
workflow_dispatch:
1414

15+
permissions:
16+
contents: read
17+
actions: read
18+
1519
jobs:
1620
validate-helm-kustomize-equivalence:
1721
runs-on: ubuntu-latest
@@ -39,4 +43,4 @@ jobs:
3943
env:
4044
VERBOSE: "true"
4145
run: |
42-
./tests/helm_compare_all_scenarios.sh
46+
./tests/helm_kustomize_compare_all.sh model-registry

.github/workflows/katib-helm-kustomize-comparison.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
1-
name: Helm vs Kustomize Comparison
1+
name: Katib Helm vs Kustomize Comparison
22

33
on:
44
pull_request:
55
branches: [master]
66
paths:
7-
- 'charts/katib/**'
8-
- 'apps/katib/upstream/**'
9-
- 'tests/compare_all_scenarios.sh'
10-
- '.github/workflows/katib-helm-kustomize-comparison.yml'
7+
- 'experimental/helm/charts/katib/**'
8+
- 'applications/katib/**'
9+
- 'tests/helm_kustomize_compare.py'
10+
- 'tests/helm_kustomize_compare.sh'
11+
- 'tests/helm_kustomize_compare_all.sh'
12+
- '.github/workflows/katib-helm-kustomize-comparison.yaml'
1113
workflow_dispatch:
1214

1315
permissions:
@@ -47,6 +49,4 @@ jobs:
4749
env:
4850
VERBOSE: "true"
4951
run: |
50-
cd tests
51-
chmod +x ./compare_all_scenarios.sh
52-
./compare_all_scenarios.sh
52+
./tests/helm_kustomize_compare_all.sh katib
Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
name: KServe Models Web App - Helm vs Kustomize Comparison
2+
3+
on:
4+
pull_request:
5+
branches: [master]
6+
paths:
7+
- 'experimental/helm/charts/kserve-models-web-app/**'
8+
- 'applications/kserve/models-web-app/**'
9+
- 'tests/helm_kustomize_compare.py'
10+
- 'tests/helm_kustomize_compare.sh'
11+
- 'tests/helm_kustomize_compare_all.sh'
12+
- '.github/workflows/kserve-models-web-app-comparison.yml'
13+
workflow_dispatch:
14+
15+
jobs:
16+
validate-models-web-app-equivalence:
17+
runs-on: ubuntu-latest
18+
name: Compare KServe Models Web App Scenarios
19+
steps:
20+
- name: Checkout code
21+
uses: actions/checkout@v4
22+
23+
- name: Set up Python
24+
uses: actions/setup-python@v4
25+
with:
26+
python-version: '3.9'
27+
28+
- name: Install Python dependencies
29+
run: |
30+
python -m pip install --upgrade pip
31+
pip install pyyaml
32+
33+
- name: Install Helm
34+
run: |
35+
curl -fsSL -o get_helm.sh https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3
36+
chmod 700 get_helm.sh
37+
./get_helm.sh
38+
rm get_helm.sh
39+
40+
- name: Install Kustomize
41+
run: ./tests/kustomize_install.sh
42+
43+
- name: Validate Helm chart
44+
run: |
45+
helm lint experimental/helm/charts/kserve-models-web-app/
46+
47+
- name: Run KServe Models Web App comparison
48+
env:
49+
VERBOSE: "true"
50+
run: ./tests/helm_kustomize_compare_all.sh kserve-models-web-app

experimental/helm/charts/katib/values.yaml

Lines changed: 47 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -94,11 +94,19 @@ controller:
9494
# -- Affinity rules for controller pods
9595
affinity: {}
9696

97-
# -- Security context for controller pods
97+
# -- Security context for controller pods
9898
podSecurityContext: {}
99-
99+
100100
# -- Security context for controller containers
101-
securityContext: {}
101+
securityContext:
102+
runAsNonRoot: true
103+
allowPrivilegeEscalation: false
104+
runAsUser: 1000
105+
seccompProfile:
106+
type: RuntimeDefault
107+
capabilities:
108+
drop:
109+
- ALL
102110

103111
# -- Extra labels for controller pods
104112
labels: {}
@@ -222,9 +230,20 @@ database:
222230
failureThreshold: 60
223231

224232
# Security context
225-
podSecurityContext: {}
233+
podSecurityContext:
234+
fsGroup: 999
235+
fsGroupChangePolicy: OnRootMismatch
226236

227-
securityContext: {}
237+
securityContext:
238+
allowPrivilegeEscalation: false
239+
seccompProfile:
240+
type: RuntimeDefault
241+
runAsNonRoot: true
242+
runAsUser: 999
243+
runAsGroup: 999
244+
capabilities:
245+
drop:
246+
- ALL
228247

229248
# Volume configuration
230249
volumes:
@@ -453,11 +472,19 @@ dbManager:
453472
# -- Affinity rules for DB Manager pods
454473
affinity: {}
455474

456-
# -- Security context for DB Manager pods
475+
# -- Security context for DB Manager pods
457476
podSecurityContext: {}
458-
477+
459478
# -- Security context for DB Manager containers
460-
securityContext: {}
479+
securityContext:
480+
runAsNonRoot: true
481+
allowPrivilegeEscalation: false
482+
runAsUser: 1000
483+
seccompProfile:
484+
type: RuntimeDefault
485+
capabilities:
486+
drop:
487+
- ALL
461488

462489
# -- Extra labels for DB Manager pods
463490
labels: {}
@@ -509,11 +536,19 @@ ui:
509536
# -- Affinity rules for UI pods
510537
affinity: {}
511538

512-
# -- Security context for UI pods
513-
podSecurityContext: {}
514-
539+
# -- Security context for UI pods
540+
podSecurityContext:
541+
seccompProfile:
542+
type: RuntimeDefault
543+
515544
# -- Security context for UI containers
516-
securityContext: {}
545+
securityContext:
546+
runAsNonRoot: true
547+
allowPrivilegeEscalation: false
548+
runAsUser: 1000
549+
capabilities:
550+
drop:
551+
- ALL
517552

518553
# -- Extra labels for UI pods
519554
labels: {}
Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
# Patterns to ignore when building packages.
2+
# This supports shell glob matching, relative path matching, and
3+
# negation (prefixed with !). Only one pattern per line.
4+
.DS_Store
5+
# Common VCS dirs
6+
.git/
7+
.gitignore
8+
.bzr/
9+
.bzrignore
10+
.hg/
11+
.hgignore
12+
.svn/
13+
# Common backup files
14+
*.swp
15+
*.bak
16+
*.tmp
17+
*.orig
18+
*~
19+
# Various IDEs
20+
.project
21+
.idea/
22+
*.tmproj
23+
.vscode/
24+
# OS generated files
25+
Thumbs.db
26+
# Helm generated files
27+
*.lock
28+
# Documentation files
29+
*.md
30+
OWNERS
31+
# CI/CD files
32+
.github/
33+
.gitlab-ci.yml
34+
.travis.yml
35+
.circleci/
36+
# Build files
37+
Makefile
38+
*.mk
39+
# Test files (keep only the test templates)
40+
test/
41+
# Scripts
42+
scripts/
43+
# Proposal files
44+
proposals/
45+
# Development environment
46+
devenv/
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
apiVersion: v2
2+
3+
name: kserve-models-web-app
4+
5+
description: A Helm chart for KServe Models Web App - Model serving management UI on Kubernetes
6+
7+
version: 0.1.0
8+
9+
appVersion: v0.14.0
10+
11+
home: https://github.com/kserve/kserve
12+
13+
annotations:
14+
category: Machine Learning
15+
licenses: Apache-2.0
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# KServe Models Web App Helm Chart
2+
3+
This Helm chart deploys the KServe Models Web App

0 commit comments

Comments
 (0)