most Application Resource Selectors are Incorrect

[thesuperzapper]

Most of the Application matchLabels don't match the Resources they should.

This is partially caused by not merging auto-PRs as raised here: #1568

I think we can reduce the complexity of these label selectors significantly, but this is really a symptom of the mess in this Repo, and highlights a need to clean it up, as raised here: #1554

A few quick examples (NOTE: there are MANY more, as pretty much every Application is affected):

• jupyter-web-app:
  • https://github.com/kubeflow/manifests/blob/master/jupyter/jupyter-web-app/overlays/application/application.yaml#L7
• pipelines:
  • https://github.com/kubeflow/manifests/blob/master/pipeline/installs/generic/application.yaml#L11
• centraldashboard:
  • https://github.com/kubeflow/manifests/blob/master/common/centraldashboard/overlays/application/application.yaml#L7
• kfserving-install:
  • https://github.com/kubeflow/manifests/blob/master/kfserving/kfserving-install/overlays/application/application.yaml#L7

[issue-label-bot]

Issue-Label Bot is automatically applying the labels:

Label	Probability
kind/bug	0.56

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

[jlewi]

/assign @thesuperzapper

@thesuperzapper What is your plan for fixing this for notebooks?

[Jeffwan]

Let's solve all the labels issue in 1.2 release. It would be great to cover these in a release runbook

[Jeffwan]

I will make a change for this issue.

/assign @Jeffwan

[thesuperzapper]

/open

This is still an issue for some components, #1646 only fixed it for wg-notebook owned components.

[thesuperzapper]

/reopen

[k8s-ci-robot]

@thesuperzapper: Reopened this issue.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.