Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@vikiival
Copy link
Member

@vikiival vikiival commented Oct 10, 2021

Thank you for your contribution to the KodaDot NFT gallery,
we really appreciate your contribution!

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting this PR, please make sure:

  • Your code builds clean without any erros or warnigns
  • You've posted screenshot of demonstrated change in this PR
  • Merged recent default branch, main and you have no conflicts
  • Didn't break any original functionality

Optional

  • You've tested it on mobile
  • Are there any edge cases? Name if any

Algo is totally different
Left current, right new
Screenshot 2021-10-10 at 23 41 57

@vikiival vikiival self-assigned this Oct 10, 2021
@vikiival vikiival requested review from roiLeo and yangwao October 10, 2021 22:01
@github-actions
Copy link
Contributor

You're Pull Request scored a 0.04040404040404041 out of a possible +5 on the sentiment scale. Here's a gif representation of your PR:
Boo from Monsters Inc blinking and looking into space neutrally

@github-actions
Copy link
Contributor

Gif

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM need it in #848

@roiLeo roiLeo mentioned this pull request Oct 11, 2021
9 tasks
@github-actions
Copy link
Contributor

Gif

@vikiival vikiival requested a review from roiLeo October 11, 2021 08:00
@yangwao
Copy link
Member

yangwao commented Oct 11, 2021

Yeah, seems more reasonable to me. Let's push it?

@yangwao yangwao merged commit d347bf7 into main Oct 11, 2021
@vikiival vikiival deleted the 861-right-numbers branch October 11, 2021 09:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants