fix(series): volume & days

[roiLeo]

PR type

• Bugfix
• Feature
• Refactoring

Before submitting this PR, please make sure:

• Code builds clean without any errors or warnings
• I've merged recent default branch -- main and I've no conflicts
• I've didn't break any original functionality
• I've posted screenshot of demonstrated change in this PR

Optional

• I've tested it on mobile and everything works

What's new? (may be part of changelog)

• sorting on series
• Sort columns in series bit more contextual #839 related
• Default series insights from highest to lowest volume #849 related
• Weird data bug on series by how many rows I show #850 related
• Are these numbers correct? #867 related

Screenshot

[vikiival]

LGTM

[roiLeo]

@vikiival could you take a look on /Search/query.ts ? I've added backend sorting

[yangwao]

It's all good to go out 👀

We still won't see negative numbers on % volume

Why is this happening?

[roiLeo]

It's all good to go out 👀

We still won't see negative numbers on % volume

Why is this happening?

Current volume:
TotalVolume = add up all nfts price from collection with "BUY" event

Current percentage:
Volume changes (%) = ((TotalVolume - TotalVolumeFromYesterday) / TotalVolume) * 100

This looks like you can't have negative numbers as current volume will always be bigger than 24h/7d/30d volume, or I could be wrong.

[yangwao]

It's all good to go out 👀

We still won't see negative numbers on % volume

Why is this happening?

Current volume: TotalVolume = add up all nfts price from collection with "BUY" event

Current percentage: Volume changes (%) = ((TotalVolume - TotalVolumeFromYesterday) / TotalVolume) * 100

This looks like you can't have negative numbers as current volume will always be bigger than 24h/7d/30d volume, or I could be wrong.

I see, legit

[roiLeo]

as (x - y) / y * 100
Wich data look better?

Volume

x = totalVolume0
y = totalVolume7dayAgo

Range

x = totalVolume>7dayAgo
y = totalVolume>14dayAgo && <7dayAgo

Data is different in the 2 case.

[yangwao]

Re range, I advised Viki to recheck numbers on small collection before we put it live, hard for me justify which seems more real 😄

…

On Fri, Oct 8, 2021, 17:55 roiLeo ***@***.***> wrote: Wich data look better? Volume [image: Screenshot 2021-10-08 at 17-46-40 KodaDot Kusama NFT Market explorer] <https://user-images.githubusercontent.com/9987732/136587144-829a31b0-884c-4c4e-be17-1504caabc75a.png> Range [image: Screenshot 2021-10-08 at 17-53-20 KodaDot Kusama NFT Market explorer] <https://user-images.githubusercontent.com/9987732/136587163-f0262c6f-7de4-40a6-8ff2-77d7bc7d98d5.png> Data is different in the 2 case. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#848 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABM5POO4S7H7AZFK4M7VR2LUF4H6HANCNFSM5FN4Y47A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[yangwao]

Can we merge this 😄