Sync rest pages #1212

dezine2dev · 2021-11-18T14:56:14Z

Thank you for your contribution to the KodaDot NFT gallery.

👇 Do a quick check before the merge.

PR type

Bugfix
Feature
Refactoring

Before submitting Pull Request, please make sure:

My contribution builds clean without any errors or warnings
I've merged recent default branch -- main-nuxt and I've no conflicts
I've tried respect high code quality standards
I've didn't break any original functionality
I've posted screenshot of demonstrated change in this PR

What's new?

PR closes Keep shortest url possible, lets remove 'en' #1154, Error on main-nuxt development mode #1189
Sync up with main, more fixes

netlify · 2021-11-18T14:56:19Z

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 3a4f111

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/6197a4f4d68ebe0008b07277

😎 Browse the preview: https://deploy-preview-1212--koda-nuxt.netlify.app

github-actions · 2021-11-18T14:56:30Z

You're Pull Request scored a 0.018018018018018018 out of a possible +5 on the sentiment scale. Here's a gif representation of your PR:

roiLeo

could you change '/rmrk/collection' route to '/rmrk/collections' as it will be showing a list of collections
'component/landing/Landing' could be move to 'pages/index'

dezine2dev · 2021-11-18T18:41:54Z

could you change '/rmrk/collection' route to '/rmrk/collections' as it will be showing a list of collections

'component/landing/Landing' could be move to 'pages/index'

Pushed new commits for these

hound · 2021-11-19T13:21:58Z

styles/global.scss

+
+    .title,
+    .card-header-title {
+        color: $text !important;


!important should not be used

hound · 2021-11-19T13:21:58Z

styles/global.scss

+        box-shadow: 0 0 4px 0.5px $primary;
+    }
+
+    .title,


Line should be indented 2 spaces, but was indented 4 spaces

hound · 2021-11-19T13:21:58Z

styles/global.scss

+    .pagination-link {
+        box-shadow: 0 0 4px 0.5px $primary;
+    }
+


Line contains trailing whitespace

hound · 2021-11-19T13:21:58Z

styles/global.scss

+        color: $primary;
+    }
+
+    .pagination-link {


Line should be indented 2 spaces, but was indented 4 spaces

hound · 2021-11-19T13:21:58Z

styles/global.scss

+        background-color: $black;
+        color: $primary;
+    }
+


Line contains trailing whitespace

hound · 2021-11-19T13:21:59Z

styles/global.scss

        font-weight: 500;
        transition: all 0.3s;
        color: $scheme-invert;
+        box-shadow: 0px 0px 3px 0.3px $primary!important;


! should be preceded by a space, and should not be followed by a space
!important should not be used
0px should be written without units as 0

hound · 2021-11-19T13:21:59Z

styles/global.scss

+    width: 100%;
 }
-
+  


Line contains trailing whitespace

hound · 2021-11-19T13:21:59Z

styles/global.scss

-  width: 100%;
+    height: 100%;
+    margin: 0;
+    width: 100%;


Line should be indented 2 spaces, but was indented 4 spaces

hound · 2021-11-19T13:21:59Z

styles/global.scss

-  margin: 0;
-  width: 100%;
+    height: 100%;
+    margin: 0;


Line should be indented 2 spaces, but was indented 4 spaces

hound · 2021-11-19T13:21:59Z

styles/global.scss

-  height: 100%;
-  margin: 0;
-  width: 100%;
+    height: 100%;


Line should be indented 2 spaces, but was indented 4 spaces

yangwao · 2021-11-20T11:20:39Z

could you change '/rmrk/collection' route to '/rmrk/collections' as it will be showing a list of collections

'component/landing/Landing' could be move to 'pages/index'

I guess this is already resolved?

roiLeo · 2021-11-20T18:17:25Z

Current route to be synchronized

'/rmrk/collections' should show list of collections
'/rmrk/collection/{id}' shoud show collectionItem

yangwao · 2021-11-21T15:39:46Z

Current route to be synchronized

'/rmrk/collections' should show list of collections

'/rmrk/collection/{id}' shoud show collectionItem

@dezine2dev 👀

yangwao · 2021-11-22T11:53:18Z

@dezine2dev continue there #1249

Merging for unblocking others.

Isa Noguchi added 4 commits November 18, 2021 23:51

Nuxt-migration: Added collection page

5013d71

Nuxt-migration: Remove en in the route

bf6c572

Nuxt-migration: Updated landing pages

eca77de

Nuxt-migration: Updated FAQ and Profile

4c8d41a

yangwao requested a review from roiLeo November 18, 2021 15:07

roiLeo suggested changes Nov 18, 2021

View reviewed changes

Isa Noguchi added 2 commits November 19, 2021 03:33

Nuxt-migration: Rename collection -> collections

f9cda54

Nuxt-migration: Move content in landing to pages/index

aebe798

Nuxt-migration: Updated styles from main and fix navigation issue

3a4f111

hound bot reviewed Nov 19, 2021

View reviewed changes

This was referenced Nov 21, 2021

Error on main-nuxt development mode #1189

Closed

Add missing routes to Nuxt #1249

Closed

yangwao merged commit 24e653c into main-nuxt Nov 22, 2021

yangwao deleted the sync-rest-pages branch November 22, 2021 11:58

yangwao mentioned this pull request Nov 22, 2021

1072: chartjs integration #1110

Merged

15 tasks

Uh oh!

Sync rest pages #1212

Sync rest pages #1212

Uh oh!

Conversation

dezine2dev commented Nov 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR type

Before submitting Pull Request, please make sure:

What's new?

Uh oh!

netlify bot commented Nov 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 18, 2021

Uh oh!

roiLeo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dezine2dev commented Nov 18, 2021

Uh oh!

hound bot Nov 19, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 19, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 19, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 19, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 19, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 19, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 19, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 19, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 19, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 19, 2021

Choose a reason for hiding this comment

Uh oh!

yangwao commented Nov 20, 2021

Uh oh!

roiLeo commented Nov 20, 2021

Current route to be synchronized

Uh oh!

yangwao commented Nov 21, 2021

Current route to be synchronized

Uh oh!

yangwao commented Nov 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dezine2dev commented Nov 18, 2021 •

edited

Loading

netlify bot commented Nov 18, 2021 •

edited

Loading

roiLeo left a comment •

edited

Loading