Skip to content
This repository was archived by the owner on Jun 29, 2022. It is now read-only.

docs/development: add section about codespell#700

Merged
knrt10 merged 1 commit intomasterfrom
invidian/codespell-docs
Jul 8, 2020
Merged

docs/development: add section about codespell#700
knrt10 merged 1 commit intomasterfrom
invidian/codespell-docs

Conversation

@invidian
Copy link
Member

@invidian invidian commented Jul 3, 2020

Closes #691

Signed-off-by: Mateusz Gozdek mateusz@kinvolk.io

@invidian invidian requested review from iaguis, johananl and surajssd July 3, 2020 08:20
Copy link
Contributor

@knrt10 knrt10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @invidian. Some small change, rest it looks good to me.


To check for typos in commit messages of your feature branch, you can run the following command:
```sh
git diff master..HEAD | grep -v ^- | codespell -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this work? AFAIK git diff doesn't show commit messages.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I copied the wrong command from my script 😄 It suppose to be git log master..HEAD | codespell - :)

Closes #691

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
@invidian invidian force-pushed the invidian/codespell-docs branch from 94cf9cc to fe89ff5 Compare July 3, 2020 09:54
@invidian invidian requested review from iaguis and knrt10 July 3, 2020 09:55
Copy link
Contributor

@knrt10 knrt10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @invidian. LGTM

Copy link
Contributor

@iaguis iaguis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@knrt10 knrt10 merged commit c1a790b into master Jul 8, 2020
@knrt10 knrt10 deleted the invidian/codespell-docs branch July 8, 2020 09:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document working with codespell while developing

3 participants