Add connection limit for thick daemon.#1510
Merged
Merged
Conversation
Co-authored-by: Takanori Hirano <me@hrntknr.net>
There was a problem hiding this comment.
Code Review
This pull request introduces a ConnectionLimit configuration option to the multus-daemon, utilizing golang.org/x/net/netutil.LimitListener to restrict simultaneous connections. It also adds an E2E test to verify this behavior. The review feedback suggests validating that the connection limit is greater than zero during startup, using an EXIT trap in the E2E test script to guarantee resource cleanup on failure, and replacing the EOL centos:8 image with a lightweight alpine:3 image in the test template.
thomasferrandiz
approved these changes
May 27, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the Connection Limit being considered below.
Related
Close: #1346
Background
When inspecting Multus itself using pprof, memory usage typically ranges from 50-60 MiB. However, since Multus launches additional CNIs, the total memory consumption of the entire container becomes the sum of all these components.
To run multus with strict memory limits, we essentially have to limit the number of parallel processes.
Therefore, the best solution would be to directly incorporate the patch previously proposed by @juliusmh.