Skip to content

Connection limit for thick daemon.#1356

Closed
juliusmh wants to merge 1 commit into
k8snetworkplumbingwg:masterfrom
juliusmh:jmh/limit_listener
Closed

Connection limit for thick daemon.#1356
juliusmh wants to merge 1 commit into
k8snetworkplumbingwg:masterfrom
juliusmh:jmh/limit_listener

Conversation

@juliusmh

Copy link
Copy Markdown
Contributor

Signed-off-by: Julius Hinze juliusmh@proton.me

Signed-off-by: Julius Hinze <juliusmh@proton.me>
@dougbtv

dougbtv commented Dec 5, 2024

Copy link
Copy Markdown
Member

Julius -- quick question: what's the difference between #1347 and this one? Could we put them together? Thanks! Went to review #1347 and then saw this one as well

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 56.403% (-0.05%) from 56.454%
when pulling 76b048b on juliusmh:jmh/limit_listener
into 781ecda on k8snetworkplumbingwg:master.

@juliusmh

juliusmh commented Dec 9, 2024

Copy link
Copy Markdown
Contributor Author

Julius -- quick question: what's the difference between #1347 and this one? Could we put them together? Thanks! Went to review #1347 and then saw this one as well

Sure. Let's proceed here.

@juliusmh

Copy link
Copy Markdown
Contributor Author

@dougbtv is this PR still considered? Is there anything I can do from my end to help get this merged?

@JensErat

JensErat commented Feb 3, 2025

Copy link
Copy Markdown

This resolved heavy OOM issues in a cluster running a larger 2-digit number of pods with multus enabled. Rebooting a node reproducible forced multus into an OOM loop, stopping all pods from running. I'd propose to additionally either add this to the configuration or even set a reasonable default value (I was randomly choosing 5).

@dougbtv does this have any chance of getting merged? Currently, we're considering whether we'll have to run a forked copy.

@github-actions

github-actions Bot commented May 5, 2025

Copy link
Copy Markdown

This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale label May 5, 2025
@github-actions github-actions Bot closed this May 12, 2025
@juliusmh

Copy link
Copy Markdown
Contributor Author

Not stale

@sunjayBhatia

Copy link
Copy Markdown

Hey @dougbtv @juliusmh we're also running into #1346 and this looks like a good candidate to help with multus+delegate CNI pod resource usage

Is there anything here we can help with that is left to do? some e2e test coverage?

@JensErat

Copy link
Copy Markdown

@dougbtv @juliusmh this is still important

@juliusmh

Copy link
Copy Markdown
Contributor Author

Reopening in #1437.

@netcho

netcho commented Oct 16, 2025

Copy link
Copy Markdown

Why is this PR closed without any mention of how to fix/workaround the scenario described?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants