Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions godotenv_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,26 @@ func TestExpanding(t *testing.T) {
"FOO=test\nBAR=\"foo\\${FOO} ${FOO}\"",
map[string]string{"FOO": "test", "BAR": "foo${FOO} test"},
},
{
"uses default value when variable is unset or empty",
`VAR="${VAR:-default}"`,
map[string]string{"VAR": "default"},
},
{
"keeps existing value with default syntax when variable is set",
"VAR=custom\nOTHER=\"${VAR:-default}\"",
map[string]string{"VAR": "custom", "OTHER": "custom"},
},
{
"uses default value when variable is unset",
`OTHER="${VAR-default}"`,
map[string]string{"OTHER": "default"},
},
{
"keeps empty value with unset-only default syntax",
"VAR=\nOTHER=\"${VAR-default}\"",
map[string]string{"VAR": "", "OTHER": ""},
},
}

for _, tt := range tests {
Expand Down
58 changes: 50 additions & 8 deletions parser.go
Original file line number Diff line number Diff line change
Expand Up @@ -263,12 +263,57 @@ func isLineEnd(r rune) bool {
}

var (
escapeRegex = regexp.MustCompile(`\\.`)
expandVarRegex = regexp.MustCompile(`(\\)?(\$)(\()?\{?([A-Z0-9_]+)?\}?`)
unescapeCharsRegex = regexp.MustCompile(`\\([^$])`)
escapeRegex = regexp.MustCompile(`\\.`)
expandVarDefaultColonRegex = regexp.MustCompile(`(\\)?\$\{([A-Z0-9_]+):-([^}]*)\}`)
expandVarUnsetDefaultRegex = regexp.MustCompile(`(\\)?\$\{([A-Z0-9_]+)-([^}]+)\}`)
expandVarRegex = regexp.MustCompile(`(\\)?(\$)(\()?\{?([A-Z0-9_]+)?\}?`)
unescapeCharsRegex = regexp.MustCompile(`\\([^$])`)
)

func lookupExpansionVar(name string, m map[string]string) (string, bool) {
if val, ok := m[name]; ok {
return val, true
}
return os.LookupEnv(name)
}

func expandVariables(v string, m map[string]string) string {
v = expandVarDefaultColonRegex.ReplaceAllStringFunc(v, func(s string) string {
submatch := expandVarDefaultColonRegex.FindStringSubmatch(s)
if submatch == nil {
return s
}
if submatch[1] == "\\" {
return submatch[0][1:]
}

name, defaultVal := submatch[2], submatch[3]
val, ok := lookupExpansionVar(name, m)
if ok && val != "" {
return val
}

return defaultVal
})

v = expandVarUnsetDefaultRegex.ReplaceAllStringFunc(v, func(s string) string {
submatch := expandVarUnsetDefaultRegex.FindStringSubmatch(s)
if submatch == nil {
return s
}
if submatch[1] == "\\" {
return submatch[0][1:]
}

name, defaultVal := submatch[2], submatch[3]
val, ok := lookupExpansionVar(name, m)
if ok {
return val
}

return defaultVal
})

return expandVarRegex.ReplaceAllStringFunc(v, func(s string) string {
submatch := expandVarRegex.FindStringSubmatch(s)

Expand All @@ -278,13 +323,10 @@ func expandVariables(v string, m map[string]string) string {
if submatch[1] == "\\" || submatch[2] == "(" {
return submatch[0][1:]
} else if submatch[4] != "" {
if val, ok := m[submatch[4]]; ok {
return val
}
if val, ok := os.LookupEnv(submatch[4]); ok {
if val, ok := lookupExpansionVar(submatch[4], m); ok {
return val
}
return m[submatch[4]]
return ""
}
return s
})
Expand Down