fix: support ${VAR:-default} parameter expansion#268
Open
leno23 wants to merge 1 commit into
Open
Conversation
Parse bash-style default value syntax in braced variable expansions so
values like "${VAR:-default}" resolve to the default when VAR is unset
or empty, and "${VAR-default}" when VAR is unset.
Fixes joho#211
leno23
force-pushed
the
fix/var-default-substitution
branch
from
7c6eca8 to
91e7bbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${VAR:-default}uses the default whenVARis unset or empty${VAR-default}uses the default only whenVARis unsetTest plan
TestExpandingfor both syntaxes and existing-value behaviorgo test ./...VAR="${VAR:-default}"now resolves todefaultFixes #211