Skip to content

Conversation

pralkarz
Copy link

@pralkarz pralkarz commented Feb 6, 2025

Works on #15189.

Summary

This is essentially a smaller #15487 – I'm aiming for a POC showcasing what snapshot changes are needed due to the differences between how chalk and picocolors work under the hood, so you can decide whether you want to go forward with this migration or not.

Test plan

yarn jest -- packages/jest-each -u – tests are passing.

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5ad1f0a
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/67a95b4effebd200088f7b2f
😎 Deploy Preview https://deploy-preview-15490--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pralkarz pralkarz marked this pull request as ready for review February 6, 2025 18:18
@pralkarz

This comment was marked as outdated.

@pralkarz pralkarz changed the title chore(jest-each): replace chalk with `picocolors chore(jest-each): replace chalk with picocolors Feb 6, 2025
Copy link

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label May 11, 2025
@pralkarz pralkarz closed this May 13, 2025
@pralkarz pralkarz deleted the jest-each-chalk-to-picocolors branch May 13, 2025 08:24
@sukjuhong
Copy link

Hi @pralkarz, I was looking into your PR and considering continuing the work from where you left off.
I was wondering if there was a particular reason the PR was paused or abandoned?
Any context you could share would be really helpful. Thanks!

@pralkarz
Copy link
Author

Hi @pralkarz, I was looking into your PR and considering continuing the work from where you left off. I was wondering if there was a particular reason the PR was paused or abandoned? Any context you could share would be really helpful. Thanks!

Hi @sukjuhong, feel free to pick it up. I closed it because it had no response for a few months, so I assumed there's no interest in the migration.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants