-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
chore: replace chalk
with picocolors
#15487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
I've opened #15490 to make it easier to gauge what snapshot changes are needed to go forward with this migration. I think it's gonna be much more comfortable to review when done package-by-package rather than opening one huge PR with thousands of lines of snapshot changes. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
With #15197 as a starting point, this PR completes the migration from
chalk
topicocolors
for most packages (the remaining ones use more advancedchalk
features not present inpicocolors
, e.g. Truecolor support). Failing tests are largely snapshots stemming from ANSI escape codes being put in different places by these two libraries, e.g.:Chalk seems to operate line-by-line, while
picocolors
sets the color once and clears it once. I could just update the snapshots, but that would result in a massive diff. What's the suggested course of action here? I could split this PR and go package-by-package instead, updating the snapshots as I go.Test plan
TBD.