-
-
Notifications
You must be signed in to change notification settings - Fork 113
Add interface based constructor for LargeText #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you open the PR to workflow api please, you can use the incremental version in Jenkins core: and then the Jenkins core dependency in workflow API, so we can see it working end 2 end. |
|
@jglick is this something you would like to take a look over? |
|
@das7pad seems you are doing something in |
jglick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK AFAICT
As suggested in #703 (review) and based on the guidance in jenkinsci/pipeline-graph-view-plugin#704 to avoid hacks in favor of upgrading the minimum Jenkins version for plugins, this PR is adding an interface based constructor for
LargeText.It will be used by the
workflow-apiplugin for a streaming based step log implementation.(das7pad/jenkins-workflow-api-plugin@71f6322#diff-fa50e2c142db03c7b1d36cd1c8bf3be413f1e375ef7d0f28ca0e1889c49238d8R384-R392 -- With this PR merged and stapler upgraded in a Jenkins weekly, we can pull it into the plugin and avoid the hack.)
Testing done
#702 has added extensive tests for all the different
LargeTextsource types. I've added another test for the interface based test.Submitter checklist