Skip to content

Conversation

@das7pad
Copy link
Contributor

@das7pad das7pad commented Sep 14, 2025

As suggested in #703 (review) and based on the guidance in jenkinsci/pipeline-graph-view-plugin#704 to avoid hacks in favor of upgrading the minimum Jenkins version for plugins, this PR is adding an interface based constructor for LargeText.

It will be used by the workflow-api plugin for a streaming based step log implementation.

(das7pad/jenkins-workflow-api-plugin@71f6322#diff-fa50e2c142db03c7b1d36cd1c8bf3be413f1e375ef7d0f28ca0e1889c49238d8R384-R392 -- With this PR merged and stapler upgraded in a Jenkins weekly, we can pull it into the plugin and avoid the hack.)

Testing done

#702 has added extensive tests for all the different LargeText source types. I've added another test for the interface based test.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@timja
Copy link
Member

timja commented Sep 14, 2025

Can you open the PR to workflow api please, you can use the incremental version in Jenkins core:
https://github.com/jenkinsci/stapler/pull/718/checks?check_run_id=50334233013

and then the Jenkins core dependency in workflow API, so we can see it working end 2 end.

@timja
Copy link
Member

timja commented Sep 16, 2025

@jglick is this something you would like to take a look over?

@timja timja requested a review from jglick September 16, 2025 10:19
@jglick
Copy link
Member

jglick commented Sep 25, 2025

@das7pad seems you are doing something in workflow-api-plugin; please file that as a draft PR, e.g. based on https://github.com/jenkinsci/jenkins/pull/11071/checks?check_run_id=50444111133

@jglick jglick requested a review from dwnusbaum October 6, 2025 13:39
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK AFAICT

@jglick jglick merged commit 10eea06 into jenkinsci:master Oct 7, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants