-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Add new LargeText interface based constructor for AnnotatedLargeText #11071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new LargeText interface based constructor for AnnotatedLargeText #11071
Conversation
|
/label developer |
|
(do not merge isn't needed if its a draft PR..) |
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
e7e6406 to
02f08b9
Compare
|
@timja have you considered adding a "fast mode" for these kinds of PRs? Spending n times 5h of compute for getting an incremental build seems quite wasteful to me. Additionally you and I spent quite some time to get all the tests to pass here. |
One way to reduce the time to generate an incremental build is to modify test/pom.xml in the pull request as follows: That is under the control of the developer submitting the pull request. The other acceleration technique for incremental builds would require changes to the Jenkinsfile to disable the Windows build and disable the acceptance test harness. That is not under the control of the developer submitting the pull request unless they are already a maintainer of Jenkins core. An example of that technique is available at https://github.com/MarkEWaite/jenkins/tree/fast-incremental |
35a14b4 to
b9bec86
Compare
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
|
@das7pad if this is ready could you update the description please |
Done. Thanks for removing the WIP changes and kicking off a build! |
|
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
A1exKH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This PR is adding an interface based constructor for
AnnotatedLargeText. Theworkflow-apiplugin will make use of it for implementing a streaming based step log (jenkinsci/workflow-api-plugin#438).Testing done
The interface based constructor is tested in stapler and jenkinsci/workflow-api-plugin#438.
Proposed changelog entries
Proposed changelog category
/remove-label work-in-progress
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).