Adjust for experimental tabs UI #1009
Conversation
|
|
||
| public class TestResultRunDetailsItem { | ||
|
|
||
| public static Optional<RunDetailsItem> get(WorkflowRun run) { |
There was a problem hiding this comment.
I thought we weren't going to delete these yet until there's replacements for them?
All of these details should move to their plugins but I don't think we should remove them until they are there yet
There was a problem hiding this comment.
Restored the Changes/Tests/Artifacts links - simplified them so they just follow Cores design.
| } | ||
|
|
||
| List<RunDetailsItem> runDetailsItems = new ArrayList<>(); | ||
| boolean githubBranchSourceInstalled = Jenkins.get().getPlugin("github-branch-source") != null; |
There was a problem hiding this comment.
Given the GitHub branch source plugin change isn't merged yet I think we should keep this?
You could maybe check its version or even if the new class exists and then not show it if you want to de-risk people getting both?
There was a problem hiding this comment.
Restored. Haven't done the class check, I'll just update this plugin once GitHub plugin has been updated.
timja
left a comment
timja
left a comment
There was a problem hiding this comment.
Noting:
- jenkinsci/jenkins#11127 (comment)
- Lack of build buttons on the page is painful, I think these are needed ASAP
- A number of 'details' are missing on the new experience
I didn't see any degradation on the default experience, defo not ready for a default toggle but not too far off from a PGV PoV.
…03f4542123 to 664.v998752b_00a_dc in /bom-weekly (#5850) * chore(deps): bump io.jenkins.plugins:pipeline-graph-view in /bom-weekly Bumps [io.jenkins.plugins:pipeline-graph-view](https://github.com/jenkinsci/pipeline-graph-view-plugin) from 661.v6003f4542123 to 664.v998752b_00a_dc. - [Release notes](https://github.com/jenkinsci/pipeline-graph-view-plugin/releases) - [Commits](https://github.com/jenkinsci/pipeline-graph-view-plugin/commits) --- updated-dependencies: - dependency-name: io.jenkins.plugins:pipeline-graph-view dependency-version: 664.v998752b_00a_dc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Pinned pipeline-graph-view plugin on 2.528.x branch Because of jenkinsci/pipeline-graph-view-plugin#1009. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adrien Lecharpentier <[email protected]>
2 participants
Before
After
After (experimental UI enabled)
What's changed?
Detailhas been removed in favour of the one fromcoreTesting done
See screenshots
Submitter checklist