-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Move experimental run sidepanel to overflow #11127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move experimental run sidepanel to overflow #11127
Conversation
timja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested with the flag on and off and all looks fine.
Strange UX currently with sub pages having the sidepanel but I guess that can be added later given this is flagged.
|
Shouldn't the button "keep this build forever" be moved to the edit button position as well? Using an appropriate icon would also make it smaller than this length text. The layout looks good! What is irritating in the beginning (but this might be related to my current usage pattern): when I open a build I normally use the trackpad to scroll to the important part of the build. Now when I scroll the trackpad I scroll the content of the console log which is not what I want. What I already mentioned in the UX meeting: the console log is totally uninteresting for me if everything went normal. So showing it in the first half part of the view is wasted space. Should other plugins already try to adapt these new UI patterns and provide experimental views as well? |
agree the text is too long and should be shortened.
Probably want the tabs feature from https://community.jenkins.io/t/a-redesigned-build-page-let-me-know-your-thoughts/35596 before then, although nothing stopping creating some experimental views / adding some things behind the feature flag. |
Yes! Wanted to keep this PR relatively small/light touch, so I've left it in the app bar for now. The intention would be to introduce/overhaul the actions API so developers can items to the overflow menu - when done it'll be easy to move that button over.
I can take a look in to that 👍
Basically what Tim said. Would definitely encourage adding flags etc and experimenting with your plugins now, I think the removal of the side panel/the additional of the top bar will allow for some interesting new designs. |
NotMyFault
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
I see. In your screenshot it seems that you moved the edit description button as well so I asked. But the screenshot is then from a different branch? |
|
Edit description is already merged: #11103 |

This is a stopgap solution for the ongoing experimental run UI overhaul. This PR moves the side panel to the overflow menu, giving more horizontal space for content below. This wouldn't be the final implementation, but would give a feeling for what it would look like. The intention would be to pull out important actions from the overflow, such as next/previous, rebuild, pipeline/tests, into the app bar so that they're quickly accessible and tabbable.
See https://community.jenkins.io/t/a-redesigned-build-page-let-me-know-your-thoughts/35596 and https://www.youtube.com/watch?v=w0Wr87Rg2jw for prototype designs.
Before

After

Testing done
Proposed changelog entries
Proposed changelog category
/label web-ui,rfe
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).