Skip to content

Conversation

@janfaracik
Copy link
Member

@janfaracik janfaracik commented Sep 29, 2025

This is a stopgap solution for the ongoing experimental run UI overhaul. This PR moves the side panel to the overflow menu, giving more horizontal space for content below. This wouldn't be the final implementation, but would give a feeling for what it would look like. The intention would be to pull out important actions from the overflow, such as next/previous, rebuild, pipeline/tests, into the app bar so that they're quickly accessible and tabbable.

See https://community.jenkins.io/t/a-redesigned-build-page-let-me-know-your-thoughts/35596 and https://www.youtube.com/watch?v=w0Wr87Rg2jw for prototype designs.

Before
image

After
image

Testing done

  • Overflow actions work as before

Proposed changelog entries

  • Move experimental run sidepanel to overflow

Proposed changelog category

/label web-ui,rfe

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@comment-ops-bot comment-ops-bot bot added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Sep 29, 2025
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested with the flag on and off and all looks fine.


Strange UX currently with sub pages having the sidepanel but I guess that can be added later given this is flagged.

@timja timja requested a review from a team September 29, 2025 12:31
@uhafner
Copy link
Member

uhafner commented Sep 30, 2025

Shouldn't the button "keep this build forever" be moved to the edit button position as well? Using an appropriate icon would also make it smaller than this length text.

The layout looks good! What is irritating in the beginning (but this might be related to my current usage pattern): when I open a build I normally use the trackpad to scroll to the important part of the build. Now when I scroll the trackpad I scroll the content of the console log which is not what I want. What I already mentioned in the UX meeting: the console log is totally uninteresting for me if everything went normal. So showing it in the first half part of the view is wasted space.

Should other plugins already try to adapt these new UI patterns and provide experimental views as well?

@timja
Copy link
Member

timja commented Sep 30, 2025

Shouldn't the button "keep this build forever" be moved to the edit button position as well? Using an appropriate icon would also make it smaller than this length text.

agree the text is too long and should be shortened.
I think out of scope of this PR though which is just about moving the sidepanel.

Should other plugins already try to adapt these new UI patterns and provide experimental views as well?

Probably want the tabs feature from https://community.jenkins.io/t/a-redesigned-build-page-let-me-know-your-thoughts/35596 before then, although nothing stopping creating some experimental views / adding some things behind the feature flag.

@janfaracik
Copy link
Member Author

Shouldn't the button "keep this build forever" be moved to the edit button position as well? Using an appropriate icon would also make it smaller than this length text.

Yes! Wanted to keep this PR relatively small/light touch, so I've left it in the app bar for now.

The intention would be to introduce/overhaul the actions API so developers can items to the overflow menu - when done it'll be easy to move that button over.

The layout looks good! What is irritating in the beginning (but this might be related to my current usage pattern): when I open a build I normally use the trackpad to scroll to the important part of the build. Now when I scroll the trackpad I scroll the content of the console log which is not what I want. What I already mentioned in the UX meeting: the console log is totally uninteresting for me if everything went normal. So showing it in the first half part of the view is wasted space.

I can take a look in to that 👍

Should other plugins already try to adapt these new UI patterns and provide experimental views as well?

Basically what Tim said. Would definitely encourage adding flags etc and experimenting with your plugins now, I think the removal of the side panel/the additional of the top bar will allow for some interesting new designs.

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@timja
Copy link
Member

timja commented Sep 30, 2025

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 30, 2025
@uhafner
Copy link
Member

uhafner commented Oct 1, 2025

Shouldn't the button "keep this build forever" be moved to the edit button position as well? Using an appropriate icon would also make it smaller than this length text.

Yes! Wanted to keep this PR relatively small/light touch, so I've left it in the app bar for now.

I see. In your screenshot it seems that you moved the edit description button as well so I asked. But the screenshot is then from a different branch?

@timja
Copy link
Member

timja commented Oct 1, 2025

Edit description is already merged: #11103

@timja timja merged commit f7c1f67 into jenkinsci:master Oct 1, 2025
18 checks passed
@timja timja deleted the move-run-sidepanel-to-overflow branch October 1, 2025 15:16
@timja
Copy link
Member

timja commented Oct 15, 2025

It bleeds through if there's color behind it:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants