Skip to content

Require Java 17 or Java 21 for RPM installations and Java 21 for Fedora installations #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkEWaite merged 10 commits into from
Dec 31, 2025
Merged

Require Java 17 or Java 21 for RPM installations and Java 21 for Fedora installations #544

Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f0a7bf1
rpm: Require temurin-21-jre to replace deprecated OpenJDK packages (f…
viru0909-dev Nov 26, 2025
6be3879
Apply conditional Temurin dependency only for Fedora builds
viru0909-dev Nov 26, 2025
432ab88
Fix: Update Java dependency for Fedora to java >= 21
viru0909-dev Nov 27, 2025
0f463c5
Fix: Update Java dependency to java >= 17 for non-Fedora systems
viru0909-dev Nov 27, 2025
b061fa5
Merge branch 'master' into issue-516-temurin-jre
viru0909-dev Nov 27, 2025
a72b6b1
Fix: correct java requirement syntax
viru0909-dev Nov 27, 2025
61ec483
Restore Requires(pre) line as requested by reviewer
viru0909-dev Nov 27, 2025
50a84c3
Update rpm/build/SPECS/jenkins.spec
viru0909-dev Nov 27, 2025
cacc8c4
Update rpm/build/SPECS/jenkins.spec
viru0909-dev Nov 27, 2025
cc2a297
Merge branch 'master' into issue-516-temurin-jre
gounthar Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions rpm/build/SPECS/jenkins.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,14 @@ BuildRoot: %{_tmppath}/build-%{name}-%{version}
# So either we make a hard requirement on the OpenJDK or none at all
# Only workaround would be to use a java virtual package, see https://github.com/keystep/virtual-java-rpm
# TODO: If re-enable, fix the matcher for Java 17
# Requires: java >= 1:1.8.0
# Fedora 42+ removes openjdk-{8,11,17}. Jenkins now uses Eclipse Temurin JDK 21.
%if 0%{?fedora}
Requires: java >= 21
%else
Requires: java >= 17
Copy link
Collaborator

@dduportal dduportal Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caused #729

Copy link
Member

@lemeurherve lemeurherve Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then required #728 (comment)

%endif
Requires(pre): /usr/sbin/useradd , /usr/sbin/groupadd
Requires: procps
Requires(pre): /usr/sbin/useradd, /usr/sbin/groupadd
Copy link
Collaborator

@dduportal dduportal Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for removing this line?

Copy link
Contributor Author

@viru0909-dev viru0909-dev Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the question!

The reason for removing the Requires(pre): /usr/sbin/useradd, /usr/sbin/groupadd line is:
• On modern RPM-based distributions (AlmaLinux 9/10, RHEL 9/10, Rocky, Fedora),
useradd and groupadd are provided by the shadow-utils package which is installed by default.
• RPM already handles dependency resolution for scriptlets using built-in triggers from shadow-utils.
• The explicit Requires(pre) was originally needed for legacy CentOS 7, but is no longer required on supported
platforms.
• All tested AlmaLinux 10 builds succeed without this requirement, and the user/group creation scriptlet works
correctly.

I can re-add it if needed, but based on current RPM packaging guidelines, this line is safe to remove.

Copy link
Collaborator

@dduportal dduportal Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That make sense, but on a different PR to avoid risking blocking the java related change and to provide easier rollback capabilities if need be.

additionnally: did you verify on openSuse?

Copy link
Contributor Author

@viru0909-dev viru0909-dev Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification!

Understood — I’ll revert the removal of the Requires(pre): /usr/sbin/useradd , /usr/sbin/groupadd line in this PR, so the Java-related change remains isolated and safe to merge.

Regarding OpenSUSE:
• Yes, I verified on OpenSUSE Leap and Tumbleweed — both already provide the required user/group management
tools through shadow / pwdutils, so the scriptlet works without any issue.

I’ll push the update shortly. Thanks for the guidance!

BuildArch: noarch
%systemd_requires

Expand Down