-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Added numeric getById to RunMap and deprecate String API #26096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
somiljain2006
wants to merge
17
commits into
jenkinsci:master
Choose a base branch
from
somiljain2006:Runmap-issue
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+52
−10
Open
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
8c0a09a
Add numeric getById to RunMap and deprecate String API
somiljain2006 bab178b
Apply suggestion from @strangelookingnerd
somiljain2006 2c89075
Apply suggestion from @strangelookingnerd
somiljain2006 82c9403
Apply suggestion from @strangelookingnerd
somiljain2006 0ed7d9c
Apply suggestion from @strangelookingnerd
somiljain2006 e12ba9b
Fixed formatting errors
somiljain2006 bc15cbe
Trigger CI rerun
somiljain2006 dc93f89
Update core/src/main/java/hudson/model/RunMap.java
somiljain2006 eb5382f
Merge branch 'master' into Runmap-issue
somiljain2006 c7e5c9d
Reverting the misunderstood change
somiljain2006 ad7145b
Merge branch 'master' into Runmap-issue
somiljain2006 c95f973
Use optimized int lookup in LazyBuildMixIn
somiljain2006 c02c8bd
Merge branch 'master' into Runmap-issue
somiljain2006 32ef88f
Revert parsing logic in LazyBuildMixIn and suppress deprecation
somiljain2006 ba2aafc
Fied formatting errors
somiljain2006 499b4b2
Remove unnecessary deprecation annotation
somiljain2006 fd55f8e
Revert "Remove unnecessary deprecation annotation"
somiljain2006 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So why is this still using a
String? The point is to get rid of all the gratuitous decimal parsing/formatting in the critical path, deprecating this stuff and leaving it as dead code.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I have reverted the changes in LazyBuildMixIn and removed the redundant parsing logic, leaving it as a simple pass-through to the deprecated RunMap#getById(String).
I also searched the codebase for internal calls to getById(String), but I didn't find any other call sites in Core that need to be migrated. If there are specific call sites I missed, please let me know, and I will update them.