-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Add support for tabs for the experimental run page #11141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
commit f998b55 Merge: 43bf0ff b2dff28 Author: Jan Faracik <[email protected]> Date: Fri Sep 26 11:31:44 2025 +0100 Merge branch 'master' into refine-description commit 43bf0ff Author: Jan Faracik <[email protected]> Date: Fri Sep 26 11:31:35 2025 +0100 Update core/src/main/resources/lib/hudson/editDescriptionButton.jelly Co-authored-by: Tim Jacomb <[email protected]> commit 5c034fb Author: Jan Faracik <[email protected]> Date: Fri Sep 26 07:30:29 2025 +0100 Change to compact attribute commit b3bd7a6 Author: Jan Faracik <[email protected]> Date: Thu Sep 25 08:07:17 2025 +0100 Refine experimental add/edit description button
|
|
||
| @Override | ||
| public String getUrlName() { | ||
| return "console"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to have: This isn't active when the page is consoleFull, i.e. when viewing a large log.
This is a pre-existing issue so not a blocker.
|
I think this is quite close, anyone else want to look it over? |
| <j:choose> | ||
| <j:when test="${newBuildPage}"> | ||
| <l:task href="${buildUrl.baseUrl}/changes" icon="symbol-changes" title="${%Changes}"/> | ||
| <p:console-link/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pipeline still needs fixing for this AFAICT (unless I need to update a plugin)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened jenkinsci/workflow-job-plugin#563 to address this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new UI! Since the UI is hidden behind a feature toggle, it makes sense to merge this change and refine it in subsequent PRs.
Things what are not perfect right now:
- Why is there a console card in the overview when there is already a tab with the same content?
- The console overview card does not fill the whole width, the bottom card does. This should be consistent. The Edit build description text area has yet another width. I think in UI design we should work more with grids.
- When I click on the edit description button, then the button disappears, I'm not sure if this is a common UI pattern.
- Having a scrollable card (console) results in a bad user experience when trying to scroll to the bottom: the mouse is captured by the console card.
- I like the new header with the tabs and previous/next buttons. I wonder, why this header is not fixed and scrolls away when scrolling down. I think it should be always visible at the top of the screen.
- This is a general UI problem in the new Jenkins design library: it is not clear for users anymore which elements are clickable, and which not. You need to hover over the element to see that it is actually a link. E.g., the "Trigger" of a build is clickable, but "Started at" and "Took" (same font and color) are not clickable.
PS: this review is only a UI review without looking at the code!
|
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
Change jenkinsci#11141 added display: flex with direction column to jenkins-card. This broke the styling of the api token display This makes the api-tokens more independent from jenkins-card
* Fix api token css Change #11141 added display: flex with direction column to jenkins-card. This broke the styling of the api token display This makes the api-tokens more independent from jenkins-card * prettier
* Fix api token css Change jenkinsci#11141 added display: flex with direction column to jenkins-card. This broke the styling of the api token display This makes the api-tokens more independent from jenkins-card * prettier
Three tabs have been added as part of this PR, them being:
Implementation
A new class
Tabhas been added, which extendsAction, to allow core and plugin developers to add items to the tab row on the experimental build UI.Plugins can opt-in to this new UI with the temporarily titled
<l:run-subpage />component, which is the frame (the build title, tabs, and actions) that wrap the plugin content.Pipeline Graph View implementation
I've opened a draft branch for Pipeline Graph View to hook into this to give everyone a better view of how this works.
See jenkinsci/pipeline-graph-view-plugin#987 for more details.
Testing done
Proposed changelog entries
Proposed changelog category
/label web-ui,rfe,developer
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).