Skip to content

Conversation

@janfaracik
Copy link
Member

@janfaracik janfaracik commented Oct 1, 2025

image Screenshot 2025-10-01 at 16 51 41

Three tabs have been added as part of this PR, them being:

  • Overview - the first person the user lands on when they open a run, it shows a high level overview of everything in said run
  • Console - the classic freestyle console view (this hides if you change the default console UI provider, e.g. to Pipeline Graph View)
  • Changes - the classic changes view

Implementation

A new class Tab has been added, which extends Action, to allow core and plugin developers to add items to the tab row on the experimental build UI.

Plugins can opt-in to this new UI with the temporarily titled <l:run-subpage /> component, which is the frame (the build title, tabs, and actions) that wrap the plugin content.

Pipeline Graph View implementation

image

I've opened a draft branch for Pipeline Graph View to hook into this to give everyone a better view of how this works.

See jenkinsci/pipeline-graph-view-plugin#987 for more details.

Testing done

Proposed changelog entries

  • Add support for tabs on the experimental run page.

Proposed changelog category

/label web-ui,rfe,developer

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

commit f998b55
Merge: 43bf0ff b2dff28
Author: Jan Faracik <[email protected]>
Date:   Fri Sep 26 11:31:44 2025 +0100

    Merge branch 'master' into refine-description

commit 43bf0ff
Author: Jan Faracik <[email protected]>
Date:   Fri Sep 26 11:31:35 2025 +0100

    Update core/src/main/resources/lib/hudson/editDescriptionButton.jelly

    Co-authored-by: Tim Jacomb <[email protected]>

commit 5c034fb
Author: Jan Faracik <[email protected]>
Date:   Fri Sep 26 07:30:29 2025 +0100

    Change to compact attribute

commit b3bd7a6
Author: Jan Faracik <[email protected]>
Date:   Thu Sep 25 08:07:17 2025 +0100

    Refine experimental add/edit description button
@timja timja requested a review from a team October 1, 2025 16:03
@comment-ops-bot comment-ops-bot bot added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted developer Changes which impact plugin developers labels Oct 1, 2025
@janfaracik janfaracik marked this pull request as ready for review October 7, 2025 08:34

@Override
public String getUrlName() {
return "console";
Copy link
Member

@timja timja Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have: This isn't active when the page is consoleFull, i.e. when viewing a large log.

This is a pre-existing issue so not a blocker.

@timja timja requested a review from a team October 7, 2025 13:06
@timja
Copy link
Member

timja commented Oct 7, 2025

I think this is quite close, anyone else want to look it over?

<j:choose>
<j:when test="${newBuildPage}">
<l:task href="${buildUrl.baseUrl}/changes" icon="symbol-changes" title="${%Changes}"/>
<p:console-link/>
Copy link
Member

@timja timja Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pipeline still needs fixing for this AFAICT (unless I need to update a plugin)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened jenkinsci/workflow-job-plugin#563 to address this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good

@timja timja requested a review from a team October 8, 2025 09:16
Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new UI! Since the UI is hidden behind a feature toggle, it makes sense to merge this change and refine it in subsequent PRs.

Things what are not perfect right now:

  • Why is there a console card in the overview when there is already a tab with the same content?
  • The console overview card does not fill the whole width, the bottom card does. This should be consistent. The Edit build description text area has yet another width. I think in UI design we should work more with grids.
Bildschirmfoto 2025-10-08 um 20 01 08
  • When I click on the edit description button, then the button disappears, I'm not sure if this is a common UI pattern.
  • Having a scrollable card (console) results in a bad user experience when trying to scroll to the bottom: the mouse is captured by the console card.
  • I like the new header with the tabs and previous/next buttons. I wonder, why this header is not fixed and scrolls away when scrolling down. I think it should be always visible at the top of the screen.
  • This is a general UI problem in the new Jenkins design library: it is not clear for users anymore which elements are clickable, and which not. You need to hover over the element to see that it is actually a link. E.g., the "Trigger" of a build is clickable, but "Started at" and "Took" (same font and color) are not clickable.

PS: this review is only a UI review without looking at the code!

@timja
Copy link
Member

timja commented Oct 8, 2025

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 8, 2025
@timja timja merged commit 893c4b5 into jenkinsci:master Oct 9, 2025
18 checks passed
@timja timja deleted the new-experimental-run-page branch October 9, 2025 21:48
mawinter69 added a commit to mawinter69/jenkins that referenced this pull request Nov 20, 2025
Change jenkinsci#11141 added display: flex with direction column to jenkins-card.
This broke the styling of the api token display
This makes the api-tokens more independent from jenkins-card
@mawinter69 mawinter69 mentioned this pull request Nov 20, 2025
14 tasks
MarkEWaite pushed a commit that referenced this pull request Nov 24, 2025
* Fix api token css

Change #11141 added display: flex with direction column to jenkins-card.
This broke the styling of the api token display
This makes the api-tokens more independent from jenkins-card

* prettier
karthikbhandary2 pushed a commit to karthikbhandary2/jenkins that referenced this pull request Dec 4, 2025
* Fix api token css

Change jenkinsci#11141 added display: flex with direction column to jenkins-card.
This broke the styling of the api token display
This makes the api-tokens more independent from jenkins-card

* prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

developer Changes which impact plugin developers ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted squash-merge-me Unclean or useless commit history, should be merged only with squash-merge web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants