Add detectOfflineLinks set to false in maven-javadoc-plugin configuration

[lemeurherve]

This PR adds this configuration in the main pom.xml to avoid the following error encountered with #11130:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.11.3:jar (attach-javadocs) on project jenkins-war: Execution attach-javadocs of goal org.apache.maven.plugins:maven-javadoc-plugin:3.11.3:jar failed: Null charset name -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.11.3:jar (attach-javadocs) on project jenkins-war: Execution attach-javadocs of goal org.apache.maven.plugins:maven-javadoc-plugin:3.11.3:jar failed: Null charset name

Refs:

• Backporting for LTS 2.528.1 RC #11130 (comment)
• Null charset name apache/maven-javadoc-plugin#1241 (comment)

Testing done

• Ran mvn --batch-mode --show-version --errors --no-transfer-progress -Pdebug -Penable-jacoco --update-snapshots -Dmaven.test.failure.ignore -DforkCount=2 -Dspotbugs.failOnError=false -Dcheckstyle.failOnViolation=false -Dset.changelist help:evaluate -Dexpression=changelist -DskipTests clean install locally and confirmed the error is gone with this change.

Proposed changelog entries

• N/A

Proposed changelog category

/label skip-changelog

Proposed upgrade guidelines

N/A

Submitter checklist

• [-] The Jira issue, if it exists, is well-described.
• [-] The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
• [-] There is automated testing or an explanation as to why this change has no tests.
• [-] New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
• [-] New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
• [-] New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
• [-] For dependency updates, there are links to external changelogs and, if possible, full differentials.
• [-] For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@timja @MarkEWaite @olamy @jglick @daniel-beck

Before the changes are marked as ready-for-merge:

Maintainer checklist

• There are at least two (2) approvals for the pull request and no outstanding requests for change.
• Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
• Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
• Proper changelog labels are set so that the changelog can be generated automatically.
• If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[lemeurherve]

/label skip-artifact-caching-proxy

[lemeurherve]

hudson.model.ComputerTest.isConnectedTest failing on Windows in this PR and #1113: https://ci.jenkins.io/job/Core/job/jenkins/job/PR-11132/2/testReport/junit/hudson.model/ComputerTest/windows_jdk17___Windows___JDK_17___Build___Test___isConnectedTest/

[timja]

Windows tests are pretty constantly failing right now

All failing for windows tests:

https://github.com/jenkinsci/jenkins/pulls?q=sort%3Aupdated-desc+is%3Apr+is%3Aopen

[lemeurherve]

Windows tests are pretty constantly failing right now

Last seen passing on master in https://ci.jenkins.io/job/Core/job/jenkins/job/master/7787/ from the 28th of September 2025.

Could it be related to #11102 or were Windows tests already failing prior this PR? EDIT: saw your own edit, nevermind.

Most Windows builds I've seen recently failed due to reclaimed Spot instances, I may have missed those with only failing tests.

[timja]

I've raised jenkins-infra/helpdesk#4818 as a single place to discuss the Windows build failures: jenkins-infra/helpdesk#4818

[lemeurherve]

Suggested change

	<!-- Avoid "Execution attach-javadocs of goal org.apache.maven.plugins:maven-javadoc-plugin:3.11.3:jar failed: Null charset name" javadoc error -->
	<!-- TODO: remove when parent POM is updated to > 1.140 -->
	<!-- Avoid "Execution attach-javadocs of goal org.apache.maven.plugins:maven-javadoc-plugin:3.11.3:jar failed: Null charset name" javadoc error -->

Should I add this TODO (and another one below L164) as the next parent pom will include maven-javadoc-plugin:3.12.0 which setdetectOfflineLinks to false by default?

Refs:

• Update dependency org.apache.maven.plugins:maven-javadoc-plugin to v3.12.0 pom#732
• https://github.com/apache/maven-javadoc-plugin/releases/tag/maven-javadoc-plugin-3.12.0
• detectOfflineLinks should be false per default (at least for javadoc:jar) apache/maven-javadoc-plugin#1258

[olly-cb]

should be fixed with upgrading javadoc plugin see apache/maven-javadoc-plugin#1259

[timja]

should be fixed with upgrading javadoc plugin see apache/maven-javadoc-plugin#1259

I've released it in the parent pom, PR here: #11139

I think we can close this