Retry failing Windows builds on non-spot agent

[lemeurherve]

This PR allows failing Windows builds to retry on a non-spot agent to avoid time loss due to spot instance reclaims, similar to what have been implemented in https://github.com/jenkinsci/acceptance-test-harness.

Note: only for Windows cf jenkins-infra/helpdesk#4790 (comment):

The maven-XX are Kubernetes (Linux) agents for which the concept of retrying to non spot makes no sense as we use Karpenter for managing nodes.

Refs:

• Helpdesk issue: Implement a retry mechanism with non-spot instance in jenkinsci/jenkins pipeline jenkins-infra/helpdesk#4790
• -nonspot agent definitions in ci.jenkins.io: feat(ci.jenkins.io): add non-spot agent definitions for Maven Windows JDK 17, 21 and 25 jenkins-infra/jenkins-infra#4380
• Similar implementation in ATH: chore(jenkinsfile): use spot instance for the first try or falls back to on-demand acceptance-test-harness#1352
• Helpdesk issue on Windows agents: [ci.jenkins.io] diagnose and eventually fix the EC2 Windows VM performances and build failures/retries jenkins-infra/helpdesk#4730

Testing done

CI: https://ci.jenkins.io/job/Core/job/jenkins/job/PR-11052/7/

Initial spot agent for Windows:

Retry non-spot agent for Windows (after manually killing the Windows agent to trigger the retry):

Proposed changelog entries

• N/A

Proposed changelog category

/label skip-changelog

Proposed upgrade guidelines

N/A

Submitter checklist

• The Jira issue, if it exists, is well-described.
• [-] The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
• There is automated testing or an explanation as to why this change has no tests.
• [-] New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
• [-] New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
• [-] New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
• [-] For dependency updates, there are links to external changelogs and, if possible, full differentials.
• [-] For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@MarkEWaite @dduportal

Before the changes are marked as ready-for-merge:

Maintainer checklist

• There are at least two (2) approvals for the pull request and no outstanding requests for change.
• Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
• Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
• Proper changelog labels are set so that the changelog can be generated automatically.
• If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[timja]

Need someone to approve my Jenkinsfile change as I don't have any permission on this repo.

I'll revert 38cb634 and switch the PR as "Ready for review" after a first build on CI showing the expected non-spot agent usage.

There's no way to 'approve' the change, can you just replay it yourself with the contents from the PR?

[lemeurherve]

can you just replay it yourself with the contents from the PR?

I currently don't have the permissions to do so.

Could someone replay https://ci.jenkins.io/job/Core/job/jenkins/job/PR-11052/1/ with the content from https://raw.githubusercontent.com/jenkinsci/jenkins/38cb6348383891c14a201d7e984072e271ee277a/Jenkinsfile please?

[timja]

@NotMyFault ran it for you

[lemeurherve]

/label skip-artifact-caching-proxy

Ref:

• artifact-caching-proxy (http://artifact-caching-proxy.artifact-caching-proxy.svc.cluster.local:8080/): status code: 502, reason phrase: Bad Gateway (502) jenkins-infra/helpdesk#4816

[lemeurherve]

Confirmed the retry working as intended (spot then non-spot) with a replay and manually killing the first Windows agent: https://ci.jenkins.io/job/Core/job/jenkins/job/PR-11052/7/

[lemeurherve]

Linux failures related to #11132