Skip to content

Overhauled RunLoadCounter #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jglick merged 1 commit into from
May 16, 2023
Merged

Overhauled RunLoadCounter #583

jglick merged 1 commit into from
May 16, 2023

Conversation

@jglick
Copy link
Member

@jglick jglick commented May 15, 2023

  • Availability of TransientActionFactory obviates the need for prepare.
  • Current project/count fields were ThreadLocal which made it impossible to test the effects of Queue.maintain.
  • Negative currCount logic was hard to follow and blocked clearer logging.

@jglick jglick added the bug label May 15, 2023
@jglick jglick requested review from a team and Vlatombe May 15, 2023 15:02
@jglick jglick mentioned this pull request May 15, 2023
Merged
6 tasks
jglick added a commit to jglick/workflow-job-plugin that referenced this pull request May 15, 2023
@jglick
Incremental deployment of jenkinsci/jenkins-test-harness#583
bacc7e8
jglick added a commit to jglick/jenkins that referenced this pull request May 15, 2023
@jglick
Incremental deployment of jenkinsci/jenkins-test-harness#583
ea65fa7
Vlatombe
Vlatombe approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@Vlatombe Vlatombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jglick jglick merged commit 0555c10 into jenkinsci:master May 16, 2023
@jglick jglick deleted the RunLoadCounter branch May 16, 2023 12:36
jglick added a commit to jglick/jenkins that referenced this pull request May 16, 2023
@jglick
Merge branch 'master' of https://github.com/jenkinsci/jenkins into ge…
4343817 
…tEstimatedDurationCandidates

jenkinsci/jenkins-test-harness#583 released.
@basil
Copy link
Member

basil commented Jun 8, 2023

Causes a test failure in PreserveStashesJobPropertyLoadTest#stashWithLoadCount as seen in jenkinsci/pipeline-model-definition-plugin#623.

@jglick jglick mentioned this pull request Jun 8, 2023
Merged
jglick added a commit to MarkEWaite/pipeline-model-definition-plugin that referenced this pull request Jun 8, 2023
@jglick
jenkinsci/jenkins-test-harness#583 makes `PreserveStashesJobPropertyL…
2aa11eb 
…oadTest` much more precise
@jglick
Copy link
Member Author

jglick commented Oct 23, 2025 •
edited
Loading

Availability of TransientActionFactory obviates the need for prepare.

Apparently broken as of jenkinsci/jenkins#11203:

java.lang.AssertionError: expected:<1> but was:<0>
	at org.jenkinsci.plugins.pipeline.modeldefinition.properties.PreserveStashesJobPropertyLoadTest$2.evaluate(PreserveStashesJobPropertyLoadTest.java:80)

@MarkEWaite MarkEWaite mentioned this pull request Oct 23, 2025
Merged
1 task
@jglick jglick mentioned this pull request Oct 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vlatombe Vlatombe Vlatombe approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jglick @basil @Vlatombe