Fixing RunLoadCounter to not assume TransientActionFactory triggers RunAction2.onLoad
#1042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs `RunAction2.onLoad`
1 task
jglick
commented
Oct 23, 2025
| /** | ||
| * Counts how many build records are loaded as a result of some task. | ||
| * @param project a project on which {@link #prepare} was called prior to creating builds | ||
| * @param project a project which may have some builds |
jglick
commented
Oct 23, 2025
| assertThat(p.getBuildByNumber(i).number, is(i)); | ||
| } | ||
| }), | ||
| is(5)); |
Member
Author
There was a problem hiding this comment.
Fails (0) without fix when run against 2.533.
alecharp
approved these changes
Oct 23, 2025
jeromepochat
approved these changes
Oct 23, 2025
Contributor
jeromepochat
left a comment
jeromepochat
left a comment
There was a problem hiding this comment.
Tested locally with org.jenkinsci.plugins.pipeline.modeldefinition.properties.PreserveStashesJobPropertyLoadTest
Thanks a lot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#583 (comment) Adapting to jenkinsci/jenkins#11203.