Fix CentOS 6 test failures#690
Merged
MarkEWaite merged 3 commits intojenkinsci:masterfrom Mar 12, 2019
Merged
Conversation
Git 2.21.0 has been released and is a good version to use.
MarkEWaite
force-pushed
the
fix-centos-6-test-failures
branch
4 times, most recently
from
d95b426 to
f75092e
Compare
Preferred to keep the tests running and passing on multiple platforms so that regressions are easier to detect.
Java 11 powermock fails due to a requirement for a Java XML module. Test is not valuable enough to wrestle with the mocking framework. Remove the test, replace it later or confirm that the case is already covered elsewhere in JenkinsRule based tests.
MarkEWaite
force-pushed
the
fix-centos-6-test-failures
branch
from
f75092e to
f925711
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip some unit tests with CLI git 1.7.1
Since CLI git 1.7.1 is not officially supported, the tests are skipped for that older version of command line git. We prefer to run tests on CentOS 6 to reduce the risk of breaking use cases that work, even knowing that the default version of command line git on CentOS 6 is not supported by the git client plugin.
Git 1.7.1 functionality gaps are described in the unit tests of the git plugin and the git client plugin.
Checklist
Types of changes