Remove upper bounds from gitVersionAtLeast#1805
Merged
MarkEWaite merged 1 commit intojenkinsci:masterfrom Sep 13, 2025
Merged
Conversation
MarkEWaite
approved these changes
Sep 13, 2025
Contributor
MarkEWaite
left a comment
MarkEWaite
left a comment
There was a problem hiding this comment.
Thanks. Change is correct and makes good sense. I never thought we would reach command line git 2.50 when this code was originally created. I was wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing jenkinsci/workflow-cps-plugin#1080 with Git 2.51.0 (built from sources locally) I noticed a warning also seen in CI
This seems senseless. What is OK about 49 but not OK about 51?
Originally introduced in 71fe2d7 and then relaxed somewhat in dff8d14 (#690).