Skip to content

[JENKINS-73676] Allow users with Job/CONFIGURE permission to edit remote URL #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkEWaite merged 1 commit into from
Aug 23, 2024
Merged

[JENKINS-73676] Allow users with Job/CONFIGURE permission to edit remote URL #1642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/jenkins/plugins/git/GitSCMSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,10 @@ public ListBoxModel doFillCredentialsIdItems(@AncestorInPath Item context,
public FormValidation doCheckRemote(@AncestorInPath Item item,
@QueryParameter String credentialsId,
@QueryParameter String remote) throws IOException, InterruptedException {
Jenkins.get().checkPermission(Jenkins.MANAGE);
if (item == null && !Jenkins.get().hasPermission(Jenkins.MANAGE) ||
item != null && !item.hasPermission(Item.CONFIGURE)) {
return FormValidation.warning("Not allowed to modify remote");
}
return isFIPSCompliantTLS(credentialsId, remote) ? FormValidation.ok() : FormValidation.error(hudson.plugins.git.Messages.git_fips_url_notsecured());
}

Expand Down