[JENKINS-73676] Allow users with Job/CONFIGURE permission to edit remote URL#1642
Merged
MarkEWaite merged 1 commit intojenkinsci:masterfrom Aug 23, 2024
Merged
Conversation
…ote URL Changes for FIPS mistakenly placed the requirement for administrator on the field when it previously allowed users with Job/CONFIGURE permission to modify the field.
olamy
approved these changes
Aug 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[JENKINS-73676] Allow users with Job/CONFIGURE permission to edit remote URL
Changes for FIPS mistakenly placed the requirement for administrator on the field when it previously allowed users with Job/CONFIGURE permission to modify the field.
Testing done
Duplicated JENKINS-73676 by installing Jenkins 2.473 with the role strategy plugin. Configured three users:
Created a fine-grained personal access token for one of my private GitHub repositories and confirmed that the repository could be read with that credential and could not be read without that credential.
Created the 'Developer-role' and assigned 'a-developer' to the role. Created the 'Reader-role' and assigned 'a-reader' to the role.
Confirmed that the 'mwaite' user could modify the URL of the remote repository before and after this change.
Confirmed that without this change, the 'a-developer' user is shown the job configuration form but sees a stack trace in the console and errors on the web page.
Confirmed that with this change, the 'a-developer' user is shown the job configuration form and is allowed to modify the URL of the remote repository.
Confirmed that the 'a-reader' user cannot see the editing form.
Submitter checklist