This repository was archived by the owner on Jul 1, 2022. It is now read-only.
Fix version retrieval from jaeger.properties#478
Merged
jpkrohling merged 1 commit intojaegertracing:masterfrom Jul 5, 2018
Merged
Fix version retrieval from jaeger.properties#478jpkrohling merged 1 commit intojaegertracing:masterfrom
jpkrohling merged 1 commit intojaegertracing:masterfrom
Conversation
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
=========================================
Coverage 88.14% 88.14%
Complexity 490 490
=========================================
Files 62 62
Lines 1848 1848
Branches 241 241
=========================================
Hits 1629 1629
Misses 142 142
Partials 77 77Continue to review full report at Codecov.
|
objectiser
approved these changes
Jul 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de
Which problem is this PR solving?
Short description of the changes
jaeger.propertiesand fixed path to it, as it's now underinternalAfter this patch is applied, this is the expected output from the Jaeger tracer: