Skip to content
This repository was archived by the owner on Jul 1, 2022. It is now read-only.
This repository was archived by the owner on Jul 1, 2022. It is now read-only.

Move to internal broke the way we retrieve version from jaeger.properties #477

@jpkrohling

Description

@jpkrohling

Requirement - what kind of business use case are you trying to solve?

The PR #470 moved the jaeger.properties file into the internal package, but failed to apply similar changes to the build scripts. This causes the tracer to misreport the version.

Problem - what in Jaeger blocks you from solving the requirement?

The following is seen when using v0.30.0:

2018-07-05 16:10:28.688  INFO 26114 --- [ost-startStop-1] io.jaegertracing.Configuration           : Initialized tracer=JaegerTracer(version=Java-0.29.1-SNAPSHOT, serviceName=customer, reporter=CompositeReporter(reporters=[RemoteReporter(queueProcessor=RemoteReporter.QueueProcessor(open=true), sender=UdpSender(udpTransport=ThriftUdpTransport(socket=java.net.DatagramSocket@5f1a4b9f, receiveBuf=null, receiveOffSet=-1, receiveLength=0)), closeEnqueueTimeout=1000), LoggingReporter(logger=Logger[io.jaegertracing.internal.reporters.LoggingReporter])]), sampler=ConstSampler(decision=true, tags={sampler.type=const, sampler.param=true}), ipv4=-1062686141, tags={hostname=caju.kroehling.de, jaeger.version=Java-0.29.1-SNAPSHOT, ip=192.168.178.67}, zipkinSharedRpcSpan=false, baggageSetter=io.jaegertracing.internal.baggage.BaggageSetter@6c20aaa2, expandExceptionLogs=false)

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions