Add nginx auth_request support #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It actually used to be the way you have it before #106. I'm going to also comment there, because it now looks like this behavior needs to be configurable. |
|
Sorry for pushing a commit It turned out by the time I adjusted the code locally to suggest a change, I had a commitable change ready to go. |
|
Noted others require the exact opposite behavior. Configurable option seems to be right solution here. |
itzg
approved these changes
Jul 22, 2025
|
just wanted to bump this. |
|
Thanks @kennethklee ...I'll assume it's ready for merge due to no further commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nginx auth_request requires either a 2xx (authenticated) or 401/403 (authentication required) response.
This updates saml-auth-proxy to respond appropriately to nginx auth_requests.
The authentication check is identical to the middleware.RequireAccount function.
middleware.RequireAccount cannot be used directly because it starts the authentication flow if not authentication, which nginx auth_request does not expect.